Bug 65664 - An element with role=textbox should have settable AXValue unless read-only
Summary: An element with role=textbox should have settable AXValue unless read-only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-03 21:17 PDT by Alice Boxhall
Modified: 2011-08-03 23:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.45 KB, patch)
2011-08-03 21:28 PDT, Alice Boxhall 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Boxhall 2011-08-03 21:17:02 PDT 
http://www.w3.org/TR/wai-aria/roles#textbox describes the WAI-ARIA textbox role. As a subclass of the "input" role, the "textbox" role allows user input. Thus, its AXValue should be marked as writable.
Comment 1 Alice Boxhall 2011-08-03 21:28:54 PDT 
Created attachment 102874 [details]
Patch
Comment 2 chris fleizach 2011-08-03 22:56:16 PDT 
Comment on attachment 102874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102874&action=review

r=me, but please remove extraneous white space

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:99
> +

please remove extraneous white space

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:656
> +

please remove extraneous white space
Comment 3 Alice Boxhall 2011-08-03 23:03:03 PDT 
Comment on attachment 102874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102874&action=review

>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:99
>> +
> 
> please remove extraneous white space

This change removes the extraneous white space which was there previously.

>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:656
>> +
> 
> please remove extraneous white space

This change removes the extraneous white space which was there previously.
Comment 4 WebKit Review Bot 2011-08-03 23:36:10 PDT 
Comment on attachment 102874 [details]
Patch

Clearing flags on attachment: 102874

Committed r92352: <http://trac.webkit.org/changeset/92352>
Comment 5 WebKit Review Bot 2011-08-03 23:36:14 PDT 
All reviewed patches have been landed.  Closing bug.