Bug 65659 - Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
Summary: Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sailesh Agrawal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-03 18:24 PDT by Sailesh Agrawal
Modified: 2011-08-03 19:35 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.96 KB, patch)
2011-08-03 18:27 PDT, Sailesh Agrawal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sailesh Agrawal 2011-08-03 18:24:39 PDT
Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
Comment 1 Sailesh Agrawal 2011-08-03 18:27:09 PDT
Created attachment 102867 [details]
Patch
Comment 2 James Robinson 2011-08-03 18:32:18 PDT
Comment on attachment 102867 [details]
Patch

OK
Comment 3 Nico Weber 2011-08-03 18:36:53 PDT
Comment on attachment 102867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102867&action=review

> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:40
>  typedef NSInteger NSScrollerStyle;

is this used anywhere?

> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:44
> +typedef uint32 wkScrollerStyle;

this is now different from before on 64bit builds. is that significant?
Comment 4 James Robinson 2011-08-03 18:39:36 PDT
Comment on attachment 102867 [details]
Patch

clearing cq, thakis' question seems relevant. he can flip cq+ when he's satisfied
Comment 5 Sailesh Agrawal 2011-08-03 18:50:19 PDT
Comment on attachment 102867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102867&action=review

>> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:40
>>  typedef NSInteger NSScrollerStyle;
> 
> is this used anywhere?

This is used inside ScrollAnimatorChromiumMac.mm and ScrollbarOverlayUtilitiesChromiumMac.mm. Having it here seemed better than having to duplicate it in both .mm files.

>> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:44
>> +typedef uint32 wkScrollerStyle;
> 
> this is now different from before on 64bit builds. is that significant?

It's not because I'm only using it for the wk* function. All delegate callback functions and private cocoa classes still use NSScrollerStyle.
Comment 6 WebKit Review Bot 2011-08-03 19:35:54 PDT
Comment on attachment 102867 [details]
Patch

Clearing flags on attachment: 102867

Committed r92343: <http://trac.webkit.org/changeset/92343>
Comment 7 WebKit Review Bot 2011-08-03 19:35:59 PDT
All reviewed patches have been landed.  Closing bug.