Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
Created attachment 102867 [details] Patch
Comment on attachment 102867 [details] Patch OK
Comment on attachment 102867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102867&action=review > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:40 > typedef NSInteger NSScrollerStyle; is this used anywhere? > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:44 > +typedef uint32 wkScrollerStyle; this is now different from before on 64bit builds. is that significant?
Comment on attachment 102867 [details] Patch clearing cq, thakis' question seems relevant. he can flip cq+ when he's satisfied
Comment on attachment 102867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102867&action=review >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:40 >> typedef NSInteger NSScrollerStyle; > > is this used anywhere? This is used inside ScrollAnimatorChromiumMac.mm and ScrollbarOverlayUtilitiesChromiumMac.mm. Having it here seemed better than having to duplicate it in both .mm files. >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:44 >> +typedef uint32 wkScrollerStyle; > > this is now different from before on 64bit builds. is that significant? It's not because I'm only using it for the wk* function. All delegate callback functions and private cocoa classes still use NSScrollerStyle.
Comment on attachment 102867 [details] Patch Clearing flags on attachment: 102867 Committed r92343: <http://trac.webkit.org/changeset/92343>
All reviewed patches have been landed. Closing bug.