Bug 65641 – JSC GC heap size improvement breaks build on some platforms due to unused parameter

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

The JSC GC heapSizeForHint() internal function does not use the heapSize parameter if !ENABLE(LARGE_HEAP), causing an unused parameter warning.

[Filip Pizlo]

Created attachment 102824 [details]
the patch

Tests still running.  Will set r=? when they finish.

[Filip Pizlo]

Comment on attachment 102824 [details]
the patch

Tests pass, ready for review.

[Darin Adler]

Comment on attachment 102824 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102824&action=review

> Source/JavaScriptCore/heap/Heap.cpp:51
> +    ASSERT_UNUSED(heapSize, heapSize == LargeHeap || heapSize == SmallHeap);

Using ASSERT_UNUSED with an argument that actually is used might cause problems in the future even if it doesn’t right now. It would be better to structure the ifdefs so the ASSERT_UNUSED is inside the #else.

[Filip Pizlo]

Created attachment 102847 [details]
the patch

[WebKit Review Bot]

Comment on attachment 102847 [details]
the patch

Rejecting attachment 102847 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 102847 [details]
the patch

Clearing flags on attachment: 102847

Committed r92329: <http://trac.webkit.org/changeset/92329>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.