Bug 65633 - Add "optimize-expectations" command to webkit-patch.
Summary: Add "optimize-expectations" command to webkit-patch.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64184
  Show dependency tree / graph
 
Reported: 2011-08-03 12:10 PDT by Dimitri Glazkov (Google)
Modified: 2011-08-03 16:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.69 KB, patch)
2011-08-03 12:11 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Patch for landing (4.66 KB, patch)
2011-08-03 14:45 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-08-03 12:10:25 PDT 
Add "optimize-expectations" command to webkit-patch.
Comment 1 Dimitri Glazkov (Google) 2011-08-03 12:11:44 PDT 
Created attachment 102807 [details]
Patch
Comment 2 Adam Barth 2011-08-03 12:37:22 PDT 
Comment on attachment 102807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102807&action=review

> Tools/Scripts/webkitpy/tool/commands/expectations.py:31
> +import os.path
> +import shutil
> +import urllib

These don't seem to be needed.

> Tools/Scripts/webkitpy/tool/commands/expectations.py:35
> +from webkitpy.layout_tests.models.test_configuration import *
> +from webkitpy.layout_tests.models.test_expectations import *

Star imports are forbidden outside of unittest files.

> Tools/Scripts/webkitpy/tool/commands/expectations.py:51
> +        port.filesystem.write_text_file(port.path_to_test_expectations_file(), TestExpectationSerializer.list_to_string(expectation_lines, converter))

You should get the filesystem from the tool.
Comment 3 Dimitri Glazkov (Google) 2011-08-03 14:45:15 PDT 
Created attachment 102831 [details]
Patch for landing
Comment 4 WebKit Review Bot 2011-08-03 16:03:47 PDT 
Comment on attachment 102831 [details]
Patch for landing

Clearing flags on attachment: 102831

Committed r92324: <http://trac.webkit.org/changeset/92324>
Comment 5 WebKit Review Bot 2011-08-03 16:03:51 PDT 
All reviewed patches have been landed.  Closing bug.