RESOLVED FIXED Bug 65633
Add "optimize-expectations" command to webkit-patch. 
https://bugs.webkit.org/show_bug.cgi?id=65633
Summary Add "optimize-expectations" command to webkit-patch.
Dimitri Glazkov (Google)
Reported 2011-08-03 12:10:25 PDT
Add "optimize-expectations" command to webkit-patch.
Attachments
Patch (4.69 KB, patch)
2011-08-03 12:11 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.66 KB, patch)
2011-08-03 14:45 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-08-03 12:11:44 PDT
Created attachment 102807 [details] Patch
Adam Barth
Comment 2 2011-08-03 12:37:22 PDT
Comment on attachment 102807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102807&action=review > Tools/Scripts/webkitpy/tool/commands/expectations.py:31 > +import os.path > +import shutil > +import urllib These don't seem to be needed. > Tools/Scripts/webkitpy/tool/commands/expectations.py:35 > +from webkitpy.layout_tests.models.test_configuration import * > +from webkitpy.layout_tests.models.test_expectations import * Star imports are forbidden outside of unittest files. > Tools/Scripts/webkitpy/tool/commands/expectations.py:51 > + port.filesystem.write_text_file(port.path_to_test_expectations_file(), TestExpectationSerializer.list_to_string(expectation_lines, converter)) You should get the filesystem from the tool.
Dimitri Glazkov (Google)
Comment 3 2011-08-03 14:45:15 PDT
Created attachment 102831 [details] Patch for landing
WebKit Review Bot
Comment 4 2011-08-03 16:03:47 PDT
Comment on attachment 102831 [details] Patch for landing Clearing flags on attachment: 102831 Committed r92324: <http://trac.webkit.org/changeset/92324>
WebKit Review Bot
Comment 5 2011-08-03 16:03:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.