RESOLVED FIXED65631
Expose Scaling Factor to Chromium Platforms 
https://bugs.webkit.org/show_bug.cgi?id=65631
Summary Expose Scaling Factor to Chromium Platforms
Fady Samuel
Reported 2011-08-03 11:40:16 PDT
Expose Scaling Factor to Chromium Platforms
Attachments
Patch (7.31 KB, patch)
2011-08-03 11:41 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (7.32 KB, patch)
2011-08-03 11:51 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2011-08-03 11:41:02 PDT
Created attachment 102803 [details] Patch
Fady Samuel
Comment 2 2011-08-03 11:51:55 PDT
Created attachment 102804 [details] Patch
Darin Fisher (:fishd, Google)
Comment 3 2011-08-03 12:07:43 PDT
This looks like a duplicate of https://bugs.webkit.org/show_bug.cgi?id=58013.
Darin Fisher (:fishd, Google)
Comment 4 2011-08-03 12:08:41 PDT
Comment on attachment 102804 [details] Patch Implementation looks good, but can you please document the difference between scaling and zooming in WebView.h. It is not obvious.
Hajime Morrita
Comment 5 2011-08-18 22:24:17 PDT
(In reply to comment #4) > (From update of attachment 102804 [details]) > Implementation looks good, but can you please document the difference between scaling and zooming in WebView.h. It is not obvious. We already has WebView::scalePage() and WebView:: pageScaleFactor(). What is difference between them? If there is no significant difference, I guess it might be nice to unify both API. It looks getting introduced for broader test coverage. http://trac.webkit.org/changeset/93381
Fady Samuel
Comment 6 2011-08-18 22:38:19 PDT
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 102804 [details] [details]) > > Implementation looks good, but can you please document the difference between scaling and zooming in WebView.h. It is not obvious. > > We already has WebView::scalePage() and WebView:: pageScaleFactor(). > What is difference between them? > If there is no significant difference, I guess it might be nice to unify both API. > > It looks getting introduced for broader test coverage. > http://trac.webkit.org/changeset/93381 This patch is no longer relevant. Marking as resolved.
Note You need to log in before you can comment on or make changes to this bug.