Bug 65631 - Expose Scaling Factor to Chromium Platforms
Summary: Expose Scaling Factor to Chromium Platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fady Samuel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-03 11:40 PDT by Fady Samuel
Modified: 2011-08-23 04:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.31 KB, patch)
2011-08-03 11:41 PDT, Fady Samuel 		no flags Details | Formatted Diff | Diff
Patch (7.32 KB, patch)
2011-08-03 11:51 PDT, Fady Samuel 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fady Samuel 2011-08-03 11:40:16 PDT 
Expose Scaling Factor to Chromium Platforms
Comment 1 Fady Samuel 2011-08-03 11:41:02 PDT 
Created attachment 102803 [details]
Patch
Comment 2 Fady Samuel 2011-08-03 11:51:55 PDT 
Created attachment 102804 [details]
Patch
Comment 3 Darin Fisher (:fishd, Google) 2011-08-03 12:07:43 PDT 
This looks like a duplicate of https://bugs.webkit.org/show_bug.cgi?id=58013.
Comment 4 Darin Fisher (:fishd, Google) 2011-08-03 12:08:41 PDT 
Comment on attachment 102804 [details]
Patch

Implementation looks good, but can you please document the difference between scaling and zooming in WebView.h.  It is not obvious.
Comment 5 Hajime Morrita 2011-08-18 22:24:17 PDT 
(In reply to comment #4)
> (From update of attachment 102804 [details])
> Implementation looks good, but can you please document the difference between scaling and zooming in WebView.h.  It is not obvious.

We already has WebView::scalePage() and WebView:: pageScaleFactor(). 
What is difference between them?
If there is no significant difference, I guess it might be nice to unify both API.

It looks getting introduced for broader test coverage.
http://trac.webkit.org/changeset/93381
Comment 6 Fady Samuel 2011-08-18 22:38:19 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 102804 [details] [details])
> > Implementation looks good, but can you please document the difference between scaling and zooming in WebView.h.  It is not obvious.
> 
> We already has WebView::scalePage() and WebView:: pageScaleFactor(). 
> What is difference between them?
> If there is no significant difference, I guess it might be nice to unify both API.
> 
> It looks getting introduced for broader test coverage.
> http://trac.webkit.org/changeset/93381

This patch is no longer relevant. Marking as resolved.