Bug 65624 - [Qt] Make navigation actions properly usable in QML.
Summary: [Qt] Make navigation actions properly usable in QML.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-08-03 09:36 PDT by Alexis Menard (darktears)
Modified: 2011-08-04 07:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (22.95 KB, patch)
2011-08-03 09:44 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Patch (23.00 KB, patch)
2011-08-04 06:54 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-08-03 09:36:28 PDT 
[Qt] Make navigation actions properly usable in QML.
Comment 1 Alexis Menard (darktears) 2011-08-03 09:44:23 PDT 
Created attachment 102791 [details]
Patch
Comment 2 Benjamin Poulain 2011-08-04 06:27:55 PDT 
Comment on attachment 102791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102791&action=review

> Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h:46
> +    QWebNavigationController* navigationController;

Look like this is leaked (in both views).
OwnPtr to the rescue? Or add QObject* parent to the constructor of QWebNavigationController.

> Source/WebKit2/UIProcess/API/qt/qwebnavigationcontroller.cpp:33
> +

ASSERT(pageProxy) maybe so it fails early in case of mistake?
Comment 3 Alexis Menard (darktears) 2011-08-04 06:54:50 PDT 
Created attachment 102906 [details]
Patch
Comment 4 Benjamin Poulain 2011-08-04 06:56:46 PDT 
Comment on attachment 102906 [details]
Patch

Looks good
Comment 5 WebKit Review Bot 2011-08-04 07:57:19 PDT 
Comment on attachment 102906 [details]
Patch

Clearing flags on attachment: 102906

Committed r92373: <http://trac.webkit.org/changeset/92373>
Comment 6 WebKit Review Bot 2011-08-04 07:57:23 PDT 
All reviewed patches have been landed.  Closing bug.