Bug 65618 – [GTK] fullscreen/video-controls-override.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

Because the test implicitely depends on the fullscreenQuickTime.css file which GTK doesn't use.


EVENT(webkitfullscreenchange)
EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
EXPECTED (panel = shadowRoot.firstChild.firstChild != 'null') OK
EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
EXPECTED (document.defaultView.getComputedStyle(panel)['height'] == '48px'), OBSERVED '600px' FAIL
EVENT(webkitfullscreenchange)
EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK
END OF TEST

[Philippe Normand]

Created attachment 102782 [details]
proposed patch

[Philippe Normand]

Before landing this we should remove:

DerivedSources/WebCore/UserAgentStyleSheetsData.cpp
DerivedSources/WebCore/UserAgentStyleSheets.h

on the bots. Or trigger a full-rebuild.

[WebKit Review Bot]

Attachment 102782 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/gtk/RenderThemeGtk.cpp:482:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Created attachment 102784 [details]
proposed patch

[Martin Robinson]

Comment on attachment 102784 [details]
proposed patch

Okay.

[Gustavo Noronha (kov)]

Comment on attachment 102784 [details]
proposed patch

Attachment 102784 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9306088

[Philippe Normand]

(In reply to comment #6)
> (From update of attachment 102784 [details])
> Attachment 102784 [details] did not pass gtk-ews (gtk):
> Output: http://queues.webkit.org/results/9306088

This was expected. :)
Gustavo, I'm ready to land this, but it requires to remove 2 files in the build directory, as mentioned in comment 2. It'd be nice to synchronize ourselves on this patch-landing!

[Philippe Normand]

Committed r92370: <http://trac.webkit.org/changeset/92370>

[Zoltan Horvath]

I triggered
http://build.webkit.sed.hu/builders/ARMv5%20Linux%20Gtk%20Release to make clean build after r92469.