Bug 65607 - Web Inspector: Console scroll position should be saved when switching panels.
Summary: Web Inspector: Console scroll position should be saved when switching panels.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-03 04:23 PDT by Vsevolod Vlasov
Modified: 2011-08-03 07:33 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.56 KB, patch)
2011-08-03 04:27 PDT, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-08-03 04:23:23 PDT 
Console scroll position should be saved when switching panels.
Comment 1 Vsevolod Vlasov 2011-08-03 04:27:05 PDT 
Created attachment 102766 [details]
Patch
Comment 2 Pavel Feldman 2011-08-03 04:44:58 PDT 
Comment on attachment 102766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102766&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:746
> +        return this.messagesElement ? this.messagesElement.scrollLeft : 0;

no need to check

> Source/WebCore/inspector/front-end/ConsoleView.js:751
> +        if (this.messagesElement)

no need to check.

> Source/WebCore/inspector/front-end/ConsoleView.js:757
> +        return this.messagesElement ? this.messagesElement.scrollTop : 0;

ditto

> Source/WebCore/inspector/front-end/ConsoleView.js:762
> +        if (this.messagesElement)

ditto
Comment 3 Vsevolod Vlasov 2011-08-03 07:33:47 PDT 
Committed r92278: <http://trac.webkit.org/changeset/92278>