Bug 65606 - [webkitpy] missing log import in common/net/resultsjsonparser.py
Summary: [webkitpy] missing log import in common/net/resultsjsonparser.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-03 04:17 PDT by Philippe Normand
Modified: 2011-08-30 23:59 PDT (History)
0 users

See Also:

Attachments
proposed patch (1.64 KB, patch)
2011-08-03 04:19 PDT, Philippe Normand 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-08-03 04:17:21 PDT 
Traceback (most recent call last):
  File "/home/phil/gst/jhbuild/build/WebKit/Tools/Scripts/webkit-patch", line 66, in <module>
    main()
  File "/home/phil/gst/jhbuild/build/WebKit/Tools/Scripts/webkit-patch", line 61, in main
    WebKitPatch(__file__).main()
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 186, in execute
    for test in self._tests_to_update(build):
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 173, in _tests_to_update
    failing_tests = build.layout_test_results().tests_matching_failure_types([test_failures.FailureTextMismatch])
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 269, in layout_test_results
    self._layout_test_results = LayoutTestResults.results_from_string(results_file)
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 137, in results_from_string
    test_results = ResultsJSONParser.parse_results_json(string)
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 149, in parse_results_json
    unexpected_failures = [result.test_result() for result in json_results if not result.did_pass_or_run_as_expected()]
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 132, in test_result
    return test_results.TestResult(self._test_name, self._failures())
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 128, in _failures
    return sum(map(self._failure_types_from_actual_result, self._actual_as_tokens()), [])
  File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 122, in _failure_types_from_actual_result
    log("Failed to handle: %s" % self._result_dict['actual'])
NameError: global name 'log' is not defined
Comment 1 Philippe Normand 2011-08-03 04:19:06 PDT 
Created attachment 102764 [details]
proposed patch
Comment 2 Philippe Normand 2011-08-30 23:59:14 PDT 
Committed r94154: <http://trac.webkit.org/changeset/94154>