Bug 65600 - [GTK] Install web and plugin processes in libexecdir instead of bindir
Summary: [GTK] Install web and plugin processes in libexecdir instead of bindir
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-08-03 02:28 PDT by Carlos Garcia Campos
Modified: 2011-08-03 05:20 PDT (History)
0 users

See Also:

Attachments
Patch (5.32 KB, patch)
2011-08-03 02:37 PDT, Carlos Garcia Campos 		mrobinson: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-08-03 02:28:05 PDT 
I think processes should be installed in libexecdir since we are a library not a program.
Comment 1 Carlos Garcia Campos 2011-08-03 02:37:38 PDT 
Created attachment 102757 [details]
Patch

An env var is used to allow MiniBrowser and unit tests (when we add them) to use web and plugin processes without having to install them.
Comment 2 Martin Robinson 2011-08-03 03:27:50 PDT 
Comment on attachment 102757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102757&action=review

> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:80
> -    GOwnPtr<gchar> binaryPath(g_build_filename(applicationDirectoryPath().data(),
> +    const gchar* execDirectory = g_getenv("WEBKIT_EXEC_PATH");
> +    GOwnPtr<gchar> binaryPath(g_build_filename(execDirectory ? execDirectory : LIBEXECDIR,

Eventually we're just going to need to break down and write a cross-platform method to get the current binary path.
Comment 3 Carlos Garcia Campos 2011-08-03 03:50:46 PDT 
Comment on attachment 102757 [details]
Patch

I've noticed this patch breaks the tests, I'm working on a new patch.
Comment 4 Carlos Garcia Campos 2011-08-03 05:20:37 PDT 
Committed r92273: <http://trac.webkit.org/changeset/92273>