Bug 65600 – [GTK] Install web and plugin processes in libexecdir instead of bindir

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

I think processes should be installed in libexecdir since we are a library not a program.

[Carlos Garcia Campos]

Created attachment 102757 [details]
Patch

An env var is used to allow MiniBrowser and unit tests (when we add them) to use web and plugin processes without having to install them.

[Martin Robinson]

Comment on attachment 102757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102757&action=review

> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:80
> -    GOwnPtr<gchar> binaryPath(g_build_filename(applicationDirectoryPath().data(),
> +    const gchar* execDirectory = g_getenv("WEBKIT_EXEC_PATH");
> +    GOwnPtr<gchar> binaryPath(g_build_filename(execDirectory ? execDirectory : LIBEXECDIR,

Eventually we're just going to need to break down and write a cross-platform method to get the current binary path.

[Carlos Garcia Campos]

Comment on attachment 102757 [details]
Patch

I've noticed this patch breaks the tests, I'm working on a new patch.

[Carlos Garcia Campos]

Committed r92273: <http://trac.webkit.org/changeset/92273>