WebSocket could not handle zero length text frame.

[Takashi Toyoshima]

In current implement, WebSocket cause UTF-8 decode frame error on zero length text frame.

cf.) Chromium side issue report: http://code.google.com/p/chromium/issues/detail?id=91193

[Takashi Toyoshima]

Created attachment 102737 [details]
Patch

[Kent Tamura]

Comment on attachment 102737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102737&action=review

> Source/WebCore/websockets/WebSocketChannel.cpp:560
>                  String message = String::fromUTF8(continuousFrameData.data(), continuousFrameData.size());
> -                if (message.isNull())
> +                if (message.isNull() && continuousFrameData.size())

Can we avoid String::fromUTF8() when continuousFrameData.size() == 0?

> Source/WebCore/websockets/WebSocketChannel.cpp:575
>              String message = String::fromUTF8(frame.payload, frame.payloadLength);
>              skipBuffer(frame.frameEnd - m_buffer);
> -            if (message.isNull())
> +            if (message.isNull() && frame.payloadLength)

ditto.

[Takashi Toyoshima]

Created attachment 102740 [details]
Patch

[Kent Tamura]

Comment on attachment 102740 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 102740 [details]
Patch

Clearing flags on attachment: 102740

Committed r92262: <http://trac.webkit.org/changeset/92262>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.