Bug 65586 - Chromium Mac: Make sure scrollbars flash when web page loads
Summary: Chromium Mac: Make sure scrollbars flash when web page loads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sailesh Agrawal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 18:11 PDT by Sailesh Agrawal
Modified: 2011-08-03 15:24 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2011-08-02 18:14 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Patch (1.92 KB, patch)
2011-08-03 14:36 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sailesh Agrawal 2011-08-02 18:11:16 PDT 
Chromium Mac: Make sure scrollbars flash when web page loads
Comment 1 Sailesh Agrawal 2011-08-02 18:14:27 PDT 
Created attachment 102726 [details]
Patch
Comment 2 Sailesh Agrawal 2011-08-02 18:15:16 PDT 
This patch fixes the following Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=90522
Comment 3 James Robinson 2011-08-03 14:27:33 PDT 
Comment on attachment 102726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102726&action=review

> Source/WebCore/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=65586
> +
> +        On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.

You need a 'Reviewed by' line here or the commit bot will reject you.
Comment 4 Sailesh Agrawal 2011-08-03 14:36:39 PDT 
Created attachment 102828 [details]
Patch
Comment 5 Sailesh Agrawal 2011-08-03 14:37:10 PDT 
> You need a 'Reviewed by' line here or the commit bot will reject you.

Fixed.
Comment 6 WebKit Review Bot 2011-08-03 15:24:26 PDT 
Comment on attachment 102828 [details]
Patch

Clearing flags on attachment: 102828

Committed r92316: <http://trac.webkit.org/changeset/92316>
Comment 7 WebKit Review Bot 2011-08-03 15:24:30 PDT 
All reviewed patches have been landed.  Closing bug.