Crash in ResourceResponse::platformCompare() with USE(CFNETWORK)

[Pratik Solanki]

Code does

    return CFEqual(a.cfURLResponse(), b.cfURLResponse());

And it crashes the cfURLResponses are 0 and CFEqual doesn't like that. This is fine on the Foundation side since we do

    return a.nsURLResponse() == b.nsURLResponse();

[Pratik Solanki]

Created attachment 102718 [details]
Patch

[Pratik Solanki]

<rdar://problem/9878360>

[Darin Adler]

Comment on attachment 102718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102718&action=review

> Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:144
> +#if PLATFORM(MAC)
> +    // CFEqual crashes if you pass it 0 and on Mac we can end up with cfURLResponse() being 0.
> +    if (!a.cfURLResponse() || !b.cfURLResponse())
> +        return a.cfURLResponse() == b.cfURLResponse();
> +#endif

This should be unconditional, not inside #if PLATFORM(MAC)

[Pratik Solanki]

Created attachment 102724 [details]
Patch

[Pratik Solanki]

Updated patch to make it unconditional.

[David Kilzer (:ddkilzer)]

Comment on attachment 102724 [details]
Patch

r=me

[Pratik Solanki]

Committed r92261: <http://trac.webkit.org/changeset/92261>