Bug 65582 – Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Joseph Pecoraro]

It looks like load/saveSessionSetting is only used in one place, for "debugger-enabled".
In fact, that has been superseded by the WebInspector.setting localStorage setting. It
looks we can just remove these functions:

  - JS: InspectorFrontendHostStub, ScriptsPanel.js usage
  - Inspector: InspectorFrontendHost + Client
  - WebKit 1 Ports: cf, mac, win and hashmap instance variable

[Pavel Feldman]

(In reply to comment #0)
> It looks like load/saveSessionSetting is only used in one place, for "debugger-enabled".
> In fact, that has been superseded by the WebInspector.setting localStorage setting. It
> looks we can just remove these functions:
> 
>   - JS: InspectorFrontendHostStub, ScriptsPanel.js usage
>   - Inspector: InspectorFrontendHost + Client
>   - WebKit 1 Ports: cf, mac, win and hashmap instance variable

You are probably right: we now have persistent localStorage settings and runtime cookie. This code should vanish. Do you have a patch pending?

[Joseph Pecoraro]

Sure I can make a patch. I just had to update my Open Source checkout. After a week
or two it takes so long I looked at other things and lost track of this! I'll assign this
to myself.

[Joseph Pecoraro]

Created attachment 102796 [details]
[PATCH] Remove the stale code

[WebKit Review Bot]

Comment on attachment 102796 [details]
[PATCH] Remove the stale code

Clearing flags on attachment: 102796

Committed r92300: <http://trac.webkit.org/changeset/92300>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.