Bug 65582 - Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
: Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-08-02 16:55 PST by
Modified: 2011-08-03 12:09 PST (History)


Attachments
[PATCH] Remove the stale code (12.52 KB, patch)
2011-08-03 11:14 PST, Joseph Pecoraro
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-08-02 16:55:23 PST
It looks like load/saveSessionSetting is only used in one place, for "debugger-enabled".
In fact, that has been superseded by the WebInspector.setting localStorage setting. It
looks we can just remove these functions:

  - JS: InspectorFrontendHostStub, ScriptsPanel.js usage
  - Inspector: InspectorFrontendHost + Client
  - WebKit 1 Ports: cf, mac, win and hashmap instance variable
------- Comment #1 From 2011-08-03 09:13:00 PST -------
(In reply to comment #0)
> It looks like load/saveSessionSetting is only used in one place, for "debugger-enabled".
> In fact, that has been superseded by the WebInspector.setting localStorage setting. It
> looks we can just remove these functions:
> 
>   - JS: InspectorFrontendHostStub, ScriptsPanel.js usage
>   - Inspector: InspectorFrontendHost + Client
>   - WebKit 1 Ports: cf, mac, win and hashmap instance variable

You are probably right: we now have persistent localStorage settings and runtime cookie. This code should vanish. Do you have a patch pending?
------- Comment #2 From 2011-08-03 10:25:56 PST -------
Sure I can make a patch. I just had to update my Open Source checkout. After a week
or two it takes so long I looked at other things and lost track of this! I'll assign this
to myself.
------- Comment #3 From 2011-08-03 11:14:27 PST -------
Created an attachment (id=102796) [details]
[PATCH] Remove the stale code
------- Comment #4 From 2011-08-03 12:09:49 PST -------
(From update of attachment 102796 [details])
Clearing flags on attachment: 102796

Committed r92300: <http://trac.webkit.org/changeset/92300>
------- Comment #5 From 2011-08-03 12:09:54 PST -------
All reviewed patches have been landed.  Closing bug.