RESOLVED FIXED 65582
Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
https://bugs.webkit.org/show_bug.cgi?id=65582
Summary Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
Joseph Pecoraro
Reported 2011-08-02 16:55:23 PDT
It looks like load/saveSessionSetting is only used in one place, for "debugger-enabled". In fact, that has been superseded by the WebInspector.setting localStorage setting. It looks we can just remove these functions: - JS: InspectorFrontendHostStub, ScriptsPanel.js usage - Inspector: InspectorFrontendHost + Client - WebKit 1 Ports: cf, mac, win and hashmap instance variable
Attachments
[PATCH] Remove the stale code (12.52 KB, patch)
2011-08-03 11:14 PDT, Joseph Pecoraro
no flags
Pavel Feldman
Comment 1 2011-08-03 09:13:00 PDT
(In reply to comment #0) > It looks like load/saveSessionSetting is only used in one place, for "debugger-enabled". > In fact, that has been superseded by the WebInspector.setting localStorage setting. It > looks we can just remove these functions: > > - JS: InspectorFrontendHostStub, ScriptsPanel.js usage > - Inspector: InspectorFrontendHost + Client > - WebKit 1 Ports: cf, mac, win and hashmap instance variable You are probably right: we now have persistent localStorage settings and runtime cookie. This code should vanish. Do you have a patch pending?
Joseph Pecoraro
Comment 2 2011-08-03 10:25:56 PDT
Sure I can make a patch. I just had to update my Open Source checkout. After a week or two it takes so long I looked at other things and lost track of this! I'll assign this to myself.
Joseph Pecoraro
Comment 3 2011-08-03 11:14:27 PDT
Created attachment 102796 [details] [PATCH] Remove the stale code
WebKit Review Bot
Comment 4 2011-08-03 12:09:49 PDT
Comment on attachment 102796 [details] [PATCH] Remove the stale code Clearing flags on attachment: 102796 Committed r92300: <http://trac.webkit.org/changeset/92300>
WebKit Review Bot
Comment 5 2011-08-03 12:09:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.