Bug 65575 – Chromium Mac: Fix position of search tickmarks

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sailesh Agrawal]

Chromium Mac: Fix position of search tickmarks

[Sailesh Agrawal]

Created attachment 102704 [details]
Patch

[James Robinson]

Comment on attachment 102704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102704&action=review

> Source/WebCore/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=65575
> +
> +        This change adjusts the position of search tickmarks so that they are correctly centered.
> +
> +        Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.

You need a 'Reviewed by' line. Is this behavior different from the mac scrollbar theme?

[Sailesh Agrawal]

> Is this behavior different from the mac scrollbar theme?

Tickmarks are specific to chromium, the mac theme doesn't have them.

[Sailesh Agrawal]

Created attachment 102827 [details]
Patch

[Sailesh Agrawal]

Comment on attachment 102704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102704&action=review

>> Source/WebCore/ChangeLog:8
>> +        Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.
> 
> You need a 'Reviewed by' line. Is this behavior different from the mac scrollbar theme?

Fixed.

[James Robinson]

Comment on attachment 102827 [details]
Patch

The Reviewed by line really should be just below the bug URL, but whatever

[WebKit Review Bot]

Comment on attachment 102827 [details]
Patch

Clearing flags on attachment: 102827

Committed r92319: <http://trac.webkit.org/changeset/92319>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.