Bug 65575 - Chromium Mac: Fix position of search tickmarks
Summary: Chromium Mac: Fix position of search tickmarks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sailesh Agrawal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 14:59 PDT by Sailesh Agrawal
Modified: 2011-08-03 15:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2011-08-02 15:04 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Patch (2.90 KB, patch)
2011-08-03 14:34 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sailesh Agrawal 2011-08-02 14:59:15 PDT 
Chromium Mac: Fix position of search tickmarks
Comment 1 Sailesh Agrawal 2011-08-02 15:04:25 PDT 
Created attachment 102704 [details]
Patch
Comment 2 James Robinson 2011-08-03 14:28:19 PDT 
Comment on attachment 102704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102704&action=review

> Source/WebCore/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=65575
> +
> +        This change adjusts the position of search tickmarks so that they are correctly centered.
> +
> +        Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.

You need a 'Reviewed by' line. Is this behavior different from the mac scrollbar theme?
Comment 3 Sailesh Agrawal 2011-08-03 14:30:08 PDT 
> Is this behavior different from the mac scrollbar theme?

Tickmarks are specific to chromium, the mac theme doesn't have them.
Comment 4 Sailesh Agrawal 2011-08-03 14:34:18 PDT 
Created attachment 102827 [details]
Patch
Comment 5 Sailesh Agrawal 2011-08-03 14:35:00 PDT 
Comment on attachment 102704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102704&action=review

>> Source/WebCore/ChangeLog:8
>> +        Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.
> 
> You need a 'Reviewed by' line. Is this behavior different from the mac scrollbar theme?

Fixed.
Comment 6 James Robinson 2011-08-03 14:43:21 PDT 
Comment on attachment 102827 [details]
Patch

The Reviewed by line really should be just below the bug URL, but whatever
Comment 7 WebKit Review Bot 2011-08-03 15:42:58 PDT 
Comment on attachment 102827 [details]
Patch

Clearing flags on attachment: 102827

Committed r92319: <http://trac.webkit.org/changeset/92319>
Comment 8 WebKit Review Bot 2011-08-03 15:43:02 PDT 
All reviewed patches have been landed.  Closing bug.