Bug 65569 – Remove LegacyDefaultOptionalArguments flag from Console.idl

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates Console.idl. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa.

[Mark Pilgrim (Google)]

Created attachment 102697 [details]
Patch

[Adam Barth]

Comment on attachment 102697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102697&action=review

> Source/WebCore/page/Console.idl:44
> -        [V8Custom, CustomArgumentHandling, ImplementationFunction=assertCondition] void assert(in boolean condition);
> +        [V8Custom, CustomArgumentHandling, ImplementationFunction=assertCondition] void assert(in [Optional=CallWithDefaultValue] boolean condition);

I suspect this attribute doesn't do anything here either because this function has CustomArgumentHandling.

> Source/WebCore/page/Console.idl:51
> +        [Custom] void profile(in [Optional=CallWithDefaultValue] DOMString title);
> +        [Custom] void profileEnd(in [Optional=CallWithDefaultValue] DOMString title);

This attribute doesn't do anything for [Custom] bindings.  We can omit it.

> Source/WebCore/page/Console.idl:55
> +        void time(in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString title);
> +        [CustomArgumentHandling] void timeEnd(in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString title);

This one might need to stay though.  I'm not sure how CustomArgumentHandling works on V8.

[Mark Pilgrim (Google)]

Created attachment 102826 [details]
Patch

[WebKit Review Bot]

Comment on attachment 102826 [details]
Patch

Clearing flags on attachment: 102826

Committed r92328: <http://trac.webkit.org/changeset/92328>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.