WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 65566
Remove LegacyDefaultOptionalArguments flag from DOMSelection.idl
https://bugs.webkit.org/show_bug.cgi?id=65566
Summary
Remove LegacyDefaultOptionalArguments flag from DOMSelection.idl
Mark Pilgrim (Google)
Reported
2011-08-02 13:57:26 PDT
As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates DOMSelection.idl. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa.
Attachments
Patch
(3.84 KB, patch)
2011-08-02 13:58 PDT
,
Mark Pilgrim (Google)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1
2011-08-02 13:58:14 PDT
Created
attachment 102694
[details]
Patch
Adam Barth
Comment 2
2011-08-03 15:03:32 PDT
Comment on
attachment 102694
[details]
Patch Aren't you a committer? If so, you should add yourself to committers.py and then you'll be able to set the cq flag yourself.
Mark Pilgrim (Google)
Comment 3
2011-08-03 15:31:01 PDT
The paperwork is still in progress.
Adam Barth
Comment 4
2011-08-03 15:38:41 PDT
Slow paperwork is slow. :(
WebKit Review Bot
Comment 5
2011-08-03 15:50:33 PDT
Comment on
attachment 102694
[details]
Patch Clearing flags on attachment: 102694 Committed
r92321
: <
http://trac.webkit.org/changeset/92321
>
WebKit Review Bot
Comment 6
2011-08-03 15:50:38 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug