Bug 65561 - Missing null check in WebViewImpl::selectionRange
Summary: Missing null check in WebViewImpl::selectionRange
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 12:31 PDT by Varun Jain
Modified: 2011-08-02 15:19 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2011-08-02 12:32 PDT, Varun Jain
no flags Details | Formatted Diff | Diff
Patch (1.38 KB, patch)
2011-08-02 13:08 PDT, Varun Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Varun Jain 2011-08-02 12:31:34 PDT
Missing null check in WebViewImpl::selectionRange
Comment 1 Varun Jain 2011-08-02 12:32:25 PDT
Created attachment 102681 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2011-08-02 13:02:44 PDT
Comment on attachment 102681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102681&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:1534
> +      return false;

nit: indentation should be 4 spaces
Comment 3 Varun Jain 2011-08-02 13:08:55 PDT
Created attachment 102688 [details]
Patch
Comment 4 Varun Jain 2011-08-02 13:09:15 PDT
(In reply to comment #2)
> (From update of attachment 102681 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102681&action=review
> 
> > Source/WebKit/chromium/src/WebViewImpl.cpp:1534
> > +      return false;
> 
> nit: indentation should be 4 spaces

Done
Comment 5 WebKit Review Bot 2011-08-02 15:19:37 PDT
Comment on attachment 102688 [details]
Patch

Clearing flags on attachment: 102688

Committed r92240: <http://trac.webkit.org/changeset/92240>
Comment 6 WebKit Review Bot 2011-08-02 15:19:41 PDT
All reviewed patches have been landed.  Closing bug.