RESOLVED FIXED 65559
Web Inspector: Pretty print JSONP in network panel preview tab. 
https://bugs.webkit.org/show_bug.cgi?id=65559
Summary Web Inspector: Pretty print JSONP in network panel preview tab.
Vsevolod Vlasov
Reported 2011-08-02 12:16:34 PDT
Pretty print scripts in network panel preview tab.
Attachments
Patch (4.60 KB, patch)
2011-08-03 09:25 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (8.23 KB, patch)
2011-08-04 07:09 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-08-03 09:25:33 PDT
Created attachment 102789 [details] Patch
Pavel Feldman
Comment 2 2011-08-03 09:40:59 PDT
Comment on attachment 102789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102789&action=review Please consider writing a test (both for preview and invalid input data. > Source/WebCore/inspector/front-end/ResourceJSONView.js:52 > + return new WebInspector.ParsedJSON(JSON.parse(text), prefix, ""); Excuse me? > Source/WebCore/inspector/front-end/ResourceJSONView.js:63 > + if (start && end) { start && end for -1 does not work. > Source/WebCore/inspector/front-end/ResourceJSONView.js:66 > + var text = text.substring(start + 1, end); Consider the following text: ")foo("! > Source/WebCore/inspector/front-end/ResourceJSONView.js:109 > + this.postfix = postfix; suffix
Vsevolod Vlasov
Comment 3 2011-08-04 07:09:25 PDT
Created attachment 102911 [details] Patch
Vsevolod Vlasov
Comment 4 2011-08-04 07:39:36 PDT
Committed r92372: <http://trac.webkit.org/changeset/92372>
Note You need to log in before you can comment on or make changes to this bug.