Bug 65551 – Web Inspector: use source-file-replaced instead of source-file-changed event.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: use source-file-replaced instead of source-file-changed event.

This is needed to support 1 -> n transitions when installing source mappings.

[Pavel Podivilov]

Created attachment 102667 [details]
Patch

[Pavel Feldman]

Comment on attachment 102667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102667&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:651
> +        this._sourceFileIdToFilesSelectOption[newSourceFile.id];

this._sourceFileIdToFilesSelectOption[newSourceFile.id] = option;

Test?

> Source/WebCore/inspector/front-end/ScriptsPanel.js:662
> +        var newSourceFrame = this._createSourceFrame(newSourceFile.id);

You should keep mapping bind/unbind close in the same location.

> Source/WebCore/inspector/front-end/SourceFile.js:63
> +            this._resource = WebInspector.networkManager.inflightResourceForURL(script.sourceURL) || WebInspector.resourceForURL(script.sourceURL);

Do we have a test that would track resource / script bindings?

[Pavel Podivilov]

Created attachment 102922 [details]
Patch

[Pavel Podivilov]

(In reply to comment #2)
> (From update of attachment 102667 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102667&action=review
> 
> > Source/WebCore/inspector/front-end/ScriptsPanel.js:651
> > +        this._sourceFileIdToFilesSelectOption[newSourceFile.id];
> 
> this._sourceFileIdToFilesSelectOption[newSourceFile.id] = option;
> 
> Test?

Added test to scripts-panel.html.

> 
> > Source/WebCore/inspector/front-end/ScriptsPanel.js:662
> > +        var newSourceFrame = this._createSourceFrame(newSourceFile.id);
> 
> You should keep mapping bind/unbind close in the same location.

Done.

> 
> > Source/WebCore/inspector/front-end/SourceFile.js:63
> > +            this._resource = WebInspector.networkManager.inflightResourceForURL(script.sourceURL) || WebInspector.resourceForURL(script.sourceURL);
> 
> Do we have a test that would track resource / script bindings?

There are test that dump source frame content, they will definitely failed if script -> resource binding is broken. I'm going to add some more dedicated tests while switching to RawSourceCode<->UISourceCode model.

[Pavel Podivilov]

Committed r92838: <http://trac.webkit.org/changeset/92838>