Bug 65549 - Web Inspector: remove Node parameter from the InspectorClient::highlight
: Web Inspector: remove Node parameter from the InspectorClient::highlight
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-08-02 10:27 PST by
Modified: 2011-08-03 01:28 PST (History)


Attachments
Patch (25.64 KB, patch)
2011-08-02 10:31 PST, Pavel Feldman
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-08-02 10:27:04 PST
It is unused + we'd like to be able to highlight not only nodes, but arbitrary regions as well.
------- Comment #1 From 2011-08-02 10:31:16 PST -------
Created an attachment (id=102666) [details]
Patch
------- Comment #2 From 2011-08-02 10:41:30 PST -------
(From update of attachment 102666 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=102666&action=review

> Source/WebCore/inspector/InspectorClient.h:47
> +    virtual void highlight() = 0;

Now that there is no Node parameter, I think we should rename the method to something that would better reflect it purpose and start with a verb, probably drawHighlight?
------- Comment #3 From 2011-08-02 10:50:46 PST -------
(In reply to comment #2)
> (From update of attachment 102666 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102666&action=review
> 
> > Source/WebCore/inspector/InspectorClient.h:47
> > +    virtual void highlight() = 0;
> 
> Now that there is no Node parameter, I think we should rename the method to something that would better reflect it purpose and start with a verb, probably drawHighlight?

My fingers are falling apart after this rename. You do that :P
------- Comment #4 From 2011-08-03 01:28:51 PST -------
(From update of attachment 102666 [details])
Clearing flags on attachment: 102666

Committed r92265: <http://trac.webkit.org/changeset/92265>
------- Comment #5 From 2011-08-03 01:28:59 PST -------
All reviewed patches have been landed.  Closing bug.