RESOLVED FIXED65549
Web Inspector: remove Node parameter from the InspectorClient::highlight 
https://bugs.webkit.org/show_bug.cgi?id=65549
Summary Web Inspector: remove Node parameter from the InspectorClient::highlight
Pavel Feldman
Reported 2011-08-02 10:27:04 PDT
It is unused + we'd like to be able to highlight not only nodes, but arbitrary regions as well.
Attachments
Patch (25.64 KB, patch)
2011-08-02 10:31 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-08-02 10:31:16 PDT
Created attachment 102666 [details] Patch
Yury Semikhatsky
Comment 2 2011-08-02 10:41:30 PDT
Comment on attachment 102666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102666&action=review > Source/WebCore/inspector/InspectorClient.h:47 > + virtual void highlight() = 0; Now that there is no Node parameter, I think we should rename the method to something that would better reflect it purpose and start with a verb, probably drawHighlight?
Pavel Feldman
Comment 3 2011-08-02 10:50:46 PDT
(In reply to comment #2) > (From update of attachment 102666 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102666&action=review > > > Source/WebCore/inspector/InspectorClient.h:47 > > + virtual void highlight() = 0; > > Now that there is no Node parameter, I think we should rename the method to something that would better reflect it purpose and start with a verb, probably drawHighlight? My fingers are falling apart after this rename. You do that :P
Pavel Feldman
Comment 4 2011-08-03 01:28:51 PDT
Comment on attachment 102666 [details] Patch Clearing flags on attachment: 102666 Committed r92265: <http://trac.webkit.org/changeset/92265>
Pavel Feldman
Comment 5 2011-08-03 01:28:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.