Bug 65545 - [Qt][WK2] Add initial support for synthetic click on WebKit2
Summary: [Qt][WK2] Add initial support for synthetic click on WebKit2
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-08-02 09:42 PDT by Benjamin Poulain
Modified: 2014-02-03 03:18 PST (History)
2 users (show)

See Also:


Attachments
Patch (15.23 KB, patch)
2011-08-02 10:08 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-08-02 09:42:38 PDT
When a touch event is not used by a page, and is not part of a gesture, we might have some other use for it... like clicking :)
Comment 1 Benjamin Poulain 2011-08-02 10:08:10 PDT
Created attachment 102664 [details]
Patch
Comment 2 Benjamin Poulain 2011-08-02 10:11:31 PDT
I tried to keep this patch nice and simple, I will grow QtTapHandler in follow up patches.
I am not a fan of the name QtTapHandler. Suggestions for a better name are welcome.

Chromium has its own implementation of synthetic click InnerGestureRecognizer::dispatchSyntheticClick(). When/If my patch goes in, I'll refactor InnerGestureRecognizer to use EventHandler directly. I did not do it here to keep things simple.
Comment 3 Antonio Gomes 2011-08-02 21:03:32 PDT
Comment on attachment 102664 [details]
Patch

LGTM.

Does it need unit tests?
Comment 4 Benjamin Poulain 2011-08-03 02:41:37 PDT
(In reply to comment #3)
> Does it need unit tests?

Yep, we really need to add tests at some point. 

But unfortunately we do not have support for the WebKitTestRunner for the touch webview yet (the view barely work at the moment).
Comment 5 Benjamin Poulain 2011-08-10 05:07:23 PDT
Comment on attachment 102664 [details]
Patch

This needs to be redone due to https://bugs.webkit.org/show_bug.cgi?id=65044
Comment 6 Jocelyn Turcotte 2014-02-03 03:18:29 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.