RESOLVED DUPLICATE of bug 83770 Bug 65541
[Qt][WK2] Prevent fractional positions for unscaled tiles with QTouchWebPage. 
https://bugs.webkit.org/show_bug.cgi?id=65541
Summary [Qt][WK2] Prevent fractional positions for unscaled tiles with QTouchWebPage.
Jocelyn Turcotte
Reported 2011-08-02 08:08:12 PDT
[Qt][WK2] Prevent fractional positions for unscaled tiles with QTouchWebPage.
Attachments
Patch (3.16 KB, patch)
2011-08-02 08:43 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2011-08-02 08:43:18 PDT
Created attachment 102657 [details] Patch
Benjamin Poulain
Comment 2 2011-08-02 10:07:06 PDT
Comment on attachment 102657 [details] Patch Why is this only for pinch? I would think TouchViewInterface::pinchGestureRequestUpdate() can be in float coordinate. Then TouchViewInterface::pinchGestureEnded() would reset the coordinate to int. And the scroll() should have the same treatment. I don't really like the idea of doing this but if that is the only way to get something looking nice...no choice :(
Jocelyn Turcotte
Comment 3 2011-08-02 10:37:02 PDT
(In reply to comment #2) > Why is this only for pinch? > I would think TouchViewInterface::pinchGestureRequestUpdate() can be in float coordinate. Then TouchViewInterface::pinchGestureEnded() would reset the coordinate to int. > And the scroll() should have the same treatment. panGestureRequestScroll always gets us int-aligned deltas since the touch events come from the viewport's coordinates which is the page's parent. I'll change scroll to take int parameters and do the same conversion to make it clearer. I tried to do the alignment in pinchGestureEnded like you say, but this would not make the pinching feel any smoother and you would get this glitch-looking frame just after releasing the finger and moving the page by 0.345px. > I don't really like the idea of doing this but if that is the only way to get something looking nice...no choice :( Samuel told me that QGraphicsView did the int-alignment itself in similar conditions, tell me if you think of a better way.
Benjamin Poulain
Comment 4 2011-08-02 18:52:54 PDT
Comment on attachment 102657 [details] Patch Clearing the review flag for now. Jocelyn will see if we can simply get the feature in the framework.
Jocelyn Turcotte
Comment 5 2013-03-19 11:35:26 PDT
Fixed using QQuickFlickable::setPixelAligned instead. *** This bug has been marked as a duplicate of bug 83770 ***
Note You need to log in before you can comment on or make changes to this bug.