Bug 65533 - Web Inspector [JSC]: Enable initiator column in network panel.
Summary: Web Inspector [JSC]: Enable initiator column in network panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 40118
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-02 05:58 PDT by Vsevolod Vlasov
Modified: 2012-07-24 03:33 PDT (History)
19 users (show)

See Also:


Attachments
Patch (7.59 KB, patch)
2012-07-07 08:43 PDT, sfa
no flags Details | Formatted Diff | Diff
Patch (13.17 KB, patch)
2012-07-13 11:18 PDT, sfa
no flags Details | Formatted Diff | Diff
Patch (14.79 KB, patch)
2012-07-23 11:32 PDT, sfa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-05 (298.18 KB, application/zip)
2012-07-23 12:25 PDT, WebKit Review Bot
no flags Details
Patch (16.46 KB, patch)
2012-07-23 13:04 PDT, sfa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-08-02 05:58:58 PDT
Enable initiator column in network panel.

Initiator column in network panel is disabled for JSC because stack trace is not available for resource triggered by javascript.
Comment 1 Vsevolod Vlasov 2011-08-02 06:00:48 PDT
Initiator column was removed from network panel in JSC in https://bugs.webkit.org/show_bug.cgi?id=65534
Comment 2 sfa 2012-07-07 08:43:01 PDT
Created attachment 151142 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-07-08 04:13:39 PDT
Comment on attachment 151142 [details]
Patch

This feature should be tested. Please make sure your patch enables http/tests/inspector/network/network-initiator.html. It is currently disabled (and broken?). :(
See https://bugs.webkit.org/show_bug.cgi?id=85038 also.
Comment 4 sfa 2012-07-12 11:59:57 PDT
Thanks for the pointer to this test but when running it, it fails on the size=200 static CSS image request. There is nothing added to the network log requests list for this image. Here is a dump of the list when searching for size=200...

find(/size=200/) http://127.0.0.1:8000/inspector/network/network-initiator.html
find(/size=200/) http://127.0.0.1:8000/inspector/network/resources/initiator.css
find(/size=200/) http://127.0.0.1:8000/inspector/inspector-test.js
find(/size=200/) http://127.0.0.1:8000/inspector/network-test.js
find(/size=200/) http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=100
find(/size=200/) http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=300
find(/size=200/) http://127.0.0.1:8000/inspector/network/resources/resource.php?type=image&random=1&size=400

I'm not qualified to fix the static CSS not adding the image request to the list so the question comes up, what should we do?

(1) hold up this change until the static CSS image request regression is fixed
(2) make a copy and tweak this test to remove the static CSS case effectively adding a test)
(3) ???

I'm partial to (2) and open to suggestions on how to change the test (I can provide my current version). Thoughts?
Comment 5 sfa 2012-07-12 12:24:14 PDT
I've confirmed that disabling caching in http://trac.webkit.org/changeset/115379/ allows the size=200 image to be recorded in the list so the regression is confirmed.
Comment 6 sfa 2012-07-13 11:18:24 PDT
Created attachment 152306 [details]
Patch
Comment 7 sfa 2012-07-13 11:20:23 PDT
Submitted a patch for my option (2), I couldn't get a chromium test output, may need help acquiring the expected output.
Comment 8 Vsevolod Vlasov 2012-07-20 05:29:04 PDT
Here is how the test could be fixed:
LayoutTests/http/tests/inspector/inspector-test.js has an Inspector.reloadPage() method that is used to reload the page in the our test. It uses PageAgent.reload() method. The parameter false passed to it means "soft reload" while in this case we need a "hard reload". 

InspectorTest.hardReloadPage() should fix it if you put the following code to inspexctor-test.js:

InspectorTest.hardReloadPage = function(callback)
{
    InspectorTest._innerReloadPage(true, callback);
}

InspectorTest.reloadPage = function(callback)
{
    InspectorTest._innerReloadPage(false, callback);
}

InspectorTest._innerReloadPage = function(hardReload, callback)
{
    InspectorTest._pageLoadedCallback = InspectorTest.safeWrap(callback);

    if (WebInspector.panels.network)
        WebInspector.panels.network._reset();
    PageAgent.reload(hardReload);
}
Comment 9 sfa 2012-07-23 11:32:24 PDT
Created attachment 153821 [details]
Patch
Comment 10 WebKit Review Bot 2012-07-23 12:25:24 PDT
Comment on attachment 153821 [details]
Patch

Attachment 153821 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13329125

New failing tests:
http/tests/inspector/network/network-initiator.html
Comment 11 WebKit Review Bot 2012-07-23 12:25:30 PDT
Created attachment 153838 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 12 sfa 2012-07-23 13:04:04 PDT
Created attachment 153848 [details]
Patch
Comment 13 Vsevolod Vlasov 2012-07-24 02:40:14 PDT
Thank you for fixing this.
Comment 14 WebKit Review Bot 2012-07-24 03:33:29 PDT
Comment on attachment 153848 [details]
Patch

Clearing flags on attachment: 153848

Committed r123452: <http://trac.webkit.org/changeset/123452>
Comment 15 WebKit Review Bot 2012-07-24 03:33:36 PDT
All reviewed patches have been landed.  Closing bug.