Bug 65527 - WebSocket should be closed by receiving unexpected continuation frame without any leading text or binary frames
Summary: WebSocket should be closed by receiving unexpected continuation frame without...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 05:09 PDT by Takashi Toyoshima
Modified: 2011-08-02 21:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.85 KB, patch)
2011-08-02 05:57 PDT, Takashi Toyoshima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Toyoshima 2011-08-02 05:09:00 PDT 
In current implement, WebSocket just ignores invalid continuation frames
which have no leading frame with FIN=0.

cf.) Chromium side issue report: http://code.google.com/p/chromium/issues/detail?id=91193
Comment 1 Takashi Toyoshima 2011-08-02 05:57:37 PDT 
Created attachment 102641 [details]
Patch
Comment 2 Kent Tamura 2011-08-02 20:38:12 PDT 
Comment on attachment 102641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102641&action=review

Looks ok.

> LayoutTests/ChangeLog:5
> +        WebSocket: Should be closed by receiving invalid continuation frame.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=65527

nit: We don't need a blank line between the summary line and the bug URL.

> Source/WebCore/ChangeLog:5
> +        WebSocket: Should be closed by receiving invalid continuation frame.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=65527

ditto.
Comment 3 WebKit Review Bot 2011-08-02 21:38:04 PDT 
Comment on attachment 102641 [details]
Patch

Clearing flags on attachment: 102641

Committed r92260: <http://trac.webkit.org/changeset/92260>
Comment 4 WebKit Review Bot 2011-08-02 21:38:09 PDT 
All reviewed patches have been landed.  Closing bug.