WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
65504
[EFL] Remove unused flags in pre-render implementation.
https://bugs.webkit.org/show_bug.cgi?id=65504
Summary
[EFL] Remove unused flags in pre-render implementation.
JungJik Lee
Reported
2011-08-01 18:18:03 PDT
A pre-render request is processed in order of priority. Hence as a pre-render concept, it is always low priority. Because tiles in viewport should be displayed first. It is not necessary to add a request in the head of the queue. And additionally to keep pace with upstream code, I try to remove _Ewk_Tiled_Backing_Store_Pre_Render_Priority flags and functions which uses the flags as a parameter.
Attachments
remove pre_render priority flags
(3.88 KB, patch)
2011-08-01 19:01 PDT
,
JungJik Lee
no flags
Details
Formatted Diff
Diff
second_patch
(3.88 KB, patch)
2011-08-11 03:49 PDT
,
JungJik Lee
no flags
Details
Formatted Diff
Diff
third patch
(3.79 KB, patch)
2011-08-21 18:16 PDT
,
JungJik Lee
no flags
Details
Formatted Diff
Diff
a new rebase patch
(4.00 KB, patch)
2011-11-10 08:57 PST
,
JungJik Lee
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
JungJik Lee
Comment 1
2011-08-01 19:01:28 PDT
Created
attachment 102611
[details]
remove pre_render priority flags
Gyuyoung Kim
Comment 2
2011-08-01 22:38:50 PDT
I think this patch needs Rafael review. So, CC'ing Rafael.
Raphael Kubo da Costa (:rakuco)
Comment 3
2011-08-02 05:40:05 PDT
LGTM from my side except for the comment below.
> Source/WebKit/efl/ChangeLog:8 > + Remove _Ewk_Tiled_Backing_Store_Pre_Render_Priority to keep pace with upstream.
Huh? This is upstream.
JungJik Lee
Comment 4
2011-08-02 18:19:28 PDT
Was upstream not a term of the latest code? Then I'll change the word. I meant 'to keep pace with the latest code'
JungJik Lee
Comment 5
2011-08-11 03:49:08 PDT
Created
attachment 103598
[details]
second_patch I've changed the comment.
Raphael Kubo da Costa (:rakuco)
Comment 6
2011-08-15 02:51:28 PDT
> Source/WebKit/efl/ChangeLog:6 > + High pre-render priority flag is not using anywhere. Only low priority is using.
How about just "The high priority pre-render flag was not used anywhere, so we can get rid of the whole concept and always consider the requests have low priority"?
JungJik Lee
Comment 7
2011-08-21 18:16:15 PDT
Created
attachment 104634
[details]
third patch No problem, I have changed the description.
Gyuyoung Kim
Comment 8
2011-08-21 21:04:54 PDT
Comment on
attachment 104634
[details]
third patch LGTM.
JungJik Lee
Comment 9
2011-11-10 08:57:43 PST
Created
attachment 114513
[details]
a new rebase patch this patch has been left for a couple of month. So I rebase and file it again.
Raphael Kubo da Costa (:rakuco)
Comment 10
2011-11-10 09:06:59 PST
Looks OK.
WebKit Review Bot
Comment 11
2011-11-11 14:30:21 PST
Comment on
attachment 114513
[details]
a new rebase patch Clearing flags on attachment: 114513 Committed
r100025
: <
http://trac.webkit.org/changeset/100025
>
WebKit Review Bot
Comment 12
2011-11-11 14:30:26 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug