Bug 65504 - [EFL] Remove unused flags in pre-render implementation.
Summary: [EFL] Remove unused flags in pre-render implementation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-01 18:18 PDT by JungJik Lee
Modified: 2011-11-11 14:30 PST (History)
7 users (show)

See Also:


Attachments
remove pre_render priority flags (3.88 KB, patch)
2011-08-01 19:01 PDT, JungJik Lee
no flags Details | Formatted Diff | Diff
second_patch (3.88 KB, patch)
2011-08-11 03:49 PDT, JungJik Lee
no flags Details | Formatted Diff | Diff
third patch (3.79 KB, patch)
2011-08-21 18:16 PDT, JungJik Lee
no flags Details | Formatted Diff | Diff
a new rebase patch (4.00 KB, patch)
2011-11-10 08:57 PST, JungJik Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JungJik Lee 2011-08-01 18:18:03 PDT
A pre-render request is processed in order of priority.
Hence as a pre-render concept, it is always low priority.
Because tiles in viewport should be displayed first.
It is not necessary to add a request in the head of the queue.
And additionally to keep pace with upstream code,
I try to remove _Ewk_Tiled_Backing_Store_Pre_Render_Priority flags and 
functions which uses the flags as a parameter.
Comment 1 JungJik Lee 2011-08-01 19:01:28 PDT
Created attachment 102611 [details]
remove pre_render priority flags
Comment 2 Gyuyoung Kim 2011-08-01 22:38:50 PDT
I think this patch needs Rafael review. So, CC'ing Rafael.
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-08-02 05:40:05 PDT
LGTM from my side except for the comment below.

> Source/WebKit/efl/ChangeLog:8
> +        Remove _Ewk_Tiled_Backing_Store_Pre_Render_Priority to keep pace with upstream.

Huh? This is upstream.
Comment 4 JungJik Lee 2011-08-02 18:19:28 PDT
Was upstream not a term of the latest code?
Then I'll change the word. I meant 'to keep pace with the latest code'
Comment 5 JungJik Lee 2011-08-11 03:49:08 PDT
Created attachment 103598 [details]
second_patch

I've changed the comment.
Comment 6 Raphael Kubo da Costa (:rakuco) 2011-08-15 02:51:28 PDT
> Source/WebKit/efl/ChangeLog:6
> +        High pre-render priority flag is not using anywhere. Only low priority is using.

How about just "The high priority pre-render flag was not used anywhere, so we can get rid of the whole concept and always consider the requests have low priority"?
Comment 7 JungJik Lee 2011-08-21 18:16:15 PDT
Created attachment 104634 [details]
third patch

No problem, I have changed the description.
Comment 8 Gyuyoung Kim 2011-08-21 21:04:54 PDT
Comment on attachment 104634 [details]
third patch

LGTM.
Comment 9 JungJik Lee 2011-11-10 08:57:43 PST
Created attachment 114513 [details]
a new rebase patch

this patch has been left for a couple of month. So I rebase and file it again.
Comment 10 Raphael Kubo da Costa (:rakuco) 2011-11-10 09:06:59 PST
Looks OK.
Comment 11 WebKit Review Bot 2011-11-11 14:30:21 PST
Comment on attachment 114513 [details]
a new rebase patch

Clearing flags on attachment: 114513

Committed r100025: <http://trac.webkit.org/changeset/100025>
Comment 12 WebKit Review Bot 2011-11-11 14:30:26 PST
All reviewed patches have been landed.  Closing bug.