Make the fullscreen JS API enabled at runtime.
Created attachment 102599 [details] Patch
Created attachment 102603 [details] Patch
Created attachment 102617 [details] Patch
Created attachment 102618 [details] Minor changes, added WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled
Thanks Adam, could you take another look? I just made some minor changes. I was wondering about the etiquette / process for making slight changes like this. Should I have just cq+ed the new patch with minor changes instead of bothering you to take another look? (Would that have worked?)
Comment on attachment 102618 [details] Minor changes, added WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled Generally, if you get an R+ with minor comments, that means you can land the patch (addressing those comments) without needing the reviewer to take another look. You can cq+ a patch even without the review flag, as long as you fill in the reviewer line in the ChangeLog manually. If you like, the "webkit-patch land-safely" command can fill in the reviewer line of the ChangeLog automatically and upload the patch with cq+ set.
Comment on attachment 102618 [details] Minor changes, added WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled Rejecting attachment 102618 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: ISO C++ forbids declaration of 'WEBKIT_API' with no type out/Debug/obj/gen/webkit/third_party/WebKit/Source/WebKit/chromium/public/../../../../../../../../../../../Source/WebKit/chromium/public/WebRuntimeFeatures.h:110: error: expected ';' before 'static' CXX(target) out/Debug/obj.target/glue/Source/WebKit/chromium/webkit/glue/websocketstreamhandle_impl.o make: *** [out/Debug/obj.target/glue/Source/WebKit/chromium/webkit/glue/webpreferences.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/9300555
WEBKIT_API got renamed to WEBKIT_EXPORT while you weren't looking. :)
Created attachment 103189 [details] Patch
Created attachment 103190 [details] Patch
(In reply to comment #6) > (From update of attachment 102618 [details]) > Generally, if you get an R+ with minor comments, that means you can land the patch (addressing those comments) without needing the reviewer to take another look. You can cq+ a patch even without the review flag, as long as you fill in the reviewer line in the ChangeLog manually. If you like, the "webkit-patch land-safely" command can fill in the reviewer line of the ChangeLog automatically and upload the patch with cq+ set. Cool! Thanks for the tip :-)
Comment on attachment 103190 [details] Patch Clearing flags on attachment: 103190 Committed r92576: <http://trac.webkit.org/changeset/92576>
All reviewed patches have been landed. Closing bug.