Bug 65498 - [chromium] Fix unresolved symbols error when linking to libwebkit.dylib
Summary: [chromium] Fix unresolved symbols error when linking to libwebkit.dylib
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-01 17:12 PDT by Nico Weber
Modified: 2011-08-02 10:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2011-08-01 17:13 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-08-01 17:12:28 PDT 
[chromium] Fix unresolved symbols error when linking to libwebkit.dylib
Comment 1 Nico Weber 2011-08-01 17:13:17 PDT 
Created attachment 102595 [details]
Patch
Comment 2 Nico Weber 2011-08-01 17:30:19 PDT 
I can has stamp? Mento says LG over email.
Comment 3 Dimitri Glazkov (Google) 2011-08-02 09:12:15 PDT 
Comment on attachment 102595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102595&action=review

> Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89
> +  # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr

Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"?
Comment 4 Nico Weber 2011-08-02 09:19:16 PDT 
(In reply to comment #3)
> > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89
> > +  # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr
> 
> Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"?

But it's "non_lazy". Isn't the negation of a demeaning word more world-improving than the negation of a kinder word?
Comment 5 Dimitri Glazkov (Google) 2011-08-02 09:20:37 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89
> > > +  # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr
> > 
> > Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"?
> 
> But it's "non_lazy". Isn't the negation of a demeaning word more world-improving than the negation of a kinder word?

Ah. I missed that. LGTM.
Comment 6 WebKit Review Bot 2011-08-02 10:33:59 PDT 
Comment on attachment 102595 [details]
Patch

Clearing flags on attachment: 102595

Committed r92203: <http://trac.webkit.org/changeset/92203>
Comment 7 WebKit Review Bot 2011-08-02 10:34:04 PDT 
All reviewed patches have been landed.  Closing bug.