Bug 65494 - RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const
Summary: RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Trivial
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-01 15:36 PDT by Julien Chaffraix
Modified: 2011-08-02 18:58 PDT (History)
2 users (show)

See Also:


Attachments
Trivial const-ness change. (38.70 KB, patch)
2011-08-01 15:44 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-08-01 15:36:31 PDT
To test some code, I wanted to call those 2 from a const method and could not without an ugly cast. Those methods return a copy of the solution and are not expected to modify the internal state so I think they satisfy the definition of const-ness as discussed on the ML.

Trivial patch forthcoming.
Comment 1 Julien Chaffraix 2011-08-01 15:44:39 PDT
Created attachment 102576 [details]
Trivial const-ness change.
Comment 2 Darin Adler 2011-08-02 17:54:25 PDT
Comment on attachment 102576 [details]
Trivial const-ness change.

OK, as long as everything called in these functions is also const.
Comment 3 WebKit Review Bot 2011-08-02 18:58:21 PDT
Comment on attachment 102576 [details]
Trivial const-ness change.

Clearing flags on attachment: 102576

Committed r92252: <http://trac.webkit.org/changeset/92252>
Comment 4 WebKit Review Bot 2011-08-02 18:58:25 PDT
All reviewed patches have been landed.  Closing bug.