Bug 65480 - cr-linux ews bot doesn't compile patch 101925
Summary: cr-linux ews bot doesn't compile patch 101925
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-01 13:02 PDT by Ian Henderson
Modified: 2011-08-02 14:02 PDT (History)
5 users (show)

See Also:

Attachments
possible reduction (1.04 KB, patch)
2011-08-01 13:02 PDT, Ian Henderson 		ian: review-
ian: commit-queue-
Details | Formatted Diff | Diff
possible reduction (1.04 KB, patch)
2011-08-01 13:12 PDT, Ian Henderson 		ian: commit-queue-
Details | Formatted Diff | Diff
possible reduction (3.42 KB, patch)
2011-08-01 15:07 PDT, Ian Henderson 		ian: commit-queue-
Details | Formatted Diff | Diff
possible reduction (4.52 KB, patch)
2011-08-01 15:48 PDT, Ian Henderson 		ian: commit-queue-
Details | Formatted Diff | Diff
possible reduction (811 bytes, patch)
2011-08-01 16:30 PDT, Ian Henderson 		ian: commit-queue-
Details | Formatted Diff | Diff
testing hypothesis (deleted)
2011-08-02 12:05 PDT, Ian Henderson 		ian: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Henderson 2011-08-01 13:02:45 PDT 
Created attachment 102545 [details]
possible reduction

For some reason the cr-linux bot is failing to compile the patches attached to https://bugs.webkit.org/show_bug.cgi?id=65006.
Comment 1 WebKit Review Bot 2011-08-01 13:05:21 PDT 
Attachment 102545 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/rendering/RenderBoxModelObj..." exit_code: 1

Source/WebCore/rendering/RenderBoxModelObject.cpp:1384:  unroundClippedCorners_ is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Ian Henderson 2011-08-01 13:12:21 PDT 
Created attachment 102547 [details]
possible reduction

This is not a real patch, please don't review.  I would r- but it causes the EWS bots to ignore the patch.
Comment 3 WebKit Review Bot 2011-08-01 13:14:18 PDT 
Attachment 102547 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/rendering/RenderBoxModelObj..." exit_code: 1

Source/WebCore/rendering/RenderBoxModelObject.cpp:1384:  unroundClippedCorners_ is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ian Henderson 2011-08-01 15:07:53 PDT 
Created attachment 102566 [details]
possible reduction
Comment 5 Ian Henderson 2011-08-01 15:48:19 PDT 
Created attachment 102578 [details]
possible reduction
Comment 6 WebKit Review Bot 2011-08-01 16:20:53 PDT 
Comment on attachment 102578 [details]
possible reduction

Attachment 102578 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9283710
Comment 7 Adam Barth 2011-08-01 16:24:49 PDT 
Source/WebCore/rendering/RenderBoxModelObject.cpp: In member function 'void WebCore::RenderBoxModelObject::paintBoxShadow(WebCore::GraphicsContext*, const WebCore::LayoutRect&, const WebCore::RenderStyle*, WebCore::ShadowStyle, bool, bool)':
Source/WebCore/rendering/RenderBoxModelObject.cpp:2249: error: 'cornersIntersect' was not declared in this scope

Do you think this is a problem with the bot or with the patch?
Comment 8 Ian Henderson 2011-08-01 16:26:05 PDT 
I'm not sure.  Evidence points to the bot, since other bots are able to compile it successfully.
Comment 9 Adam Barth 2011-08-01 16:28:24 PDT 
> I'm not sure.  Evidence points to the bot, since other bots are able to compile it successfully.

I bet it will break compile on chromium-linux if you landed it.  I'm not sure what's different about the chromium linux configuration that causes the problem.
Comment 10 Ian Henderson 2011-08-01 16:30:06 PDT 
Created attachment 102590 [details]
possible reduction
Comment 11 Ian Henderson 2011-08-01 16:31:32 PDT 
(In reply to comment #9)
> > I'm not sure.  Evidence points to the bot, since other bots are able to compile it successfully.
> 
> I bet it will break compile on chromium-linux if you landed it.  I'm not sure what's different about the chromium linux configuration that causes the problem.

Yeah, hopefully it will be more clear with a reduction.
Comment 12 WebKit Review Bot 2011-08-01 16:59:07 PDT 
Comment on attachment 102590 [details]
possible reduction

Attachment 102590 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9285575
Comment 13 Adam Barth 2011-08-01 17:19:15 PDT 
How bizzare.  gcc bug?
Comment 14 Ian Henderson 2011-08-01 21:04:31 PDT 
(In reply to comment #13)
> How bizzare.  gcc bug?

What version of GCC is cr-linux using?  Should I try to work around it, or is this a false alarm?
Comment 15 Adam Barth 2011-08-02 00:06:10 PDT 
> What version of GCC is cr-linux using?  Should I try to work around it, or is this a false alarm?

Whatever comes with Ubuntu Lucid.  If you'd be willing to work around the issue, that would be helpful.  Maybe evmar or tony^work knows more about what's going on.
Comment 16 Tony Chang 2011-08-02 10:09:05 PDT 
someStaticFunction is inside a #if HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) block of code.  Is that true for Linux/Skia?
Comment 17 Ian Henderson 2011-08-02 12:05:57 PDT 
Created attachment 102675 [details]
testing hypothesis

Nice catch!  Let's see what happens if we move the definition outside the #if block.
Comment 18 Ian Henderson 2011-08-02 14:02:33 PDT 
Yes, that looks like it was it.  I should have thought to check for #if directives earlier.  Thanks Tony!