Bug 65476 - Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
Summary: Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-01 10:09 PDT by Andrey Kosyakov
Modified: 2011-11-30 09:37 PST (History)
12 users (show)

See Also:

Attachments
patch (5.96 KB, patch)
2011-08-01 10:28 PDT, Andrey Kosyakov 		yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-08-01 10:09:04 PDT 
Somehow, the test for webInspector.inspectedPage.reload() added in Bug 51485 wasn't landed. This lead to webInspector.inspectedPage.reload() being eventaully broken by a change in inspector backend interface (PageAgent.setUserAgentOverride() -> NetworkAgent.setUserAgentOverride()).
Comment 1 Andrey Kosyakov 2011-08-01 10:28:10 PDT 
Created attachment 102533 [details]
patch

- Fixed webInspector.inspectedPage.reload()
- Broguht back tests for the above
- Removed redundant user-agent override from FrameLoader::loadResourceSynchronously(), this should happen indirectly via a call to addExtraFieldsToSubresourceRequest()
Comment 2 WebKit Review Bot 2011-08-01 11:12:31 PDT 
Comment on attachment 102533 [details]
patch

Attachment 102533 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9290455

New failing tests:
http/tests/inspector/extensions-useragent.html
Comment 3 Andrey Kosyakov 2011-11-30 09:37:04 PST 
Manually committed r92187: http://trac.webkit.org/changeset/92187