Bug 65475 – Shard webcore_remaining for msvs official builds

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Bradley Nelson]

webcore_remaining has consistently exceeded Visual Studio 2008's capacity to link when link time code generation is turned on (full release builds).
This has been dealt with the past by carving off larger and larger pieces of webcore_remaining (ie webcore_html, webcore_renderer etc).
A new option has been added to gyp to automate this sharding:
'msvs_shard': SHARD_COUNT,
Targets marked in this way will be built in several pieces (target_0, target_1...).
Since the resulting project is less comprehensible in the IDE (and since the linking limitation only afflicts official builds), this option is only needed for those builds.
This patch shards webcore_remaining into 10 parts for official builds.

[Bradley Nelson]

Created attachment 102528 [details]
Patch to turn on msvs_shard for webcore_remaining

[Bradley Nelson]

Created attachment 102572 [details]
Patch to turn on msvs shard for webcore remaining (fixed base)

[WebKit Review Bot]

Attachment 102572 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Bradley Nelson]

Created attachment 102582 [details]
Patch to turn on msvs shard for webcore remaining (fixed style errors)

[Darin Fisher (:fishd, Google)]

Comment on attachment 102582 [details]
Patch to turn on msvs shard for webcore remaining (fixed style errors)

Nice solution!

[WebKit Review Bot]

Comment on attachment 102582 [details]
Patch to turn on msvs shard for webcore remaining (fixed style errors)

Rejecting attachment 102582 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
5f5733bee9b1d4a89117bc2427a2dda3cf50b276
r92155 = a6205c70d9357b95d08b4ecc380bfe7ef06ed0ac
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9290560

[Adam Barth]

Comment on attachment 102582 [details]
Patch to turn on msvs shard for webcore remaining (fixed style errors)

The ChangeLog is missing the "Reviewed by" line.

[Adam Barth]

Created attachment 102600 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 102600 [details]
Patch for landing

Clearing flags on attachment: 102600

Committed r92159: <http://trac.webkit.org/changeset/92159>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.