Bug 65465 - [Qt] OpenGLShims does not build on ARM
Summary: [Qt] OpenGLShims does not build on ARM
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
Keywords: Qt, QtTriaged
Depends on: 57154
  Show dependency treegraph
Reported: 2011-08-01 06:20 PDT by Benjamin Poulain
Modified: 2011-08-01 09:10 PDT (History)
3 users (show)

See Also:

Patch (5.51 KB, patch)
2011-08-01 06:27 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (4.84 KB, patch)
2011-08-01 06:52 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-08-01 06:20:35 PDT
Some of the compilation issues:
-lookupOpenGLFunctionAddress defined but not used
-glBlitFramebuffer && glRenderbufferStorageMultisample undefined symbols on OpenGL ES 2
-GLchar not defined (although the official header defines it)
Comment 1 Benjamin Poulain 2011-08-01 06:27:43 PDT
Created attachment 102511 [details]
Comment 2 Benjamin Poulain 2011-08-01 06:31:13 PDT
This patch is just a build fix.

To get everything right, the code using glBlitFramebuffer and glRenderbufferStorageMultisample should check if the functions exist at runtime. Alternatively, the code using those function could be #ifdefined as well but that would spread in a rather ugly way.

typedef char GLchar;
seems to work on GCC but I doubt that is portable. If someone has a better idea, I'd be glad to update that line :)
Comment 3 Early Warning System Bot 2011-08-01 06:39:16 PDT
Comment on attachment 102511 [details]

Attachment 102511 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9289319
Comment 4 Benjamin Poulain 2011-08-01 06:52:31 PDT
Created attachment 102513 [details]
Comment 5 WebKit Review Bot 2011-08-01 09:10:27 PDT
Comment on attachment 102513 [details]

Clearing flags on attachment: 102513

Committed r92130: <http://trac.webkit.org/changeset/92130>
Comment 6 WebKit Review Bot 2011-08-01 09:10:31 PDT
All reviewed patches have been landed.  Closing bug.