65457 – Web Inspector: typing an expression in an iframe leads to multiple "Unsafe JavaScript attempt to access frame..." errors

Bug 65457 - Web Inspector: typing an expression in an iframe leads to multiple "Unsafe JavaScript attempt to access frame..." errors

Summary: Web Inspector: typing an expression in an iframe leads to multiple "Unsafe Ja...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (Deprecated) (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Yury Semikhatsky

URL:
Keywords:

Depends on:
Blocks:

Reported:	2011-08-01 02:22 PDT by Yury Semikhatsky
Modified:	2011-08-01 04:43 PDT (History)
CC List:	12 users (show)

See Also:

Attachments
Patch (29.58 KB, patch) 2011-08-01 02:31 PDT, Yury Semikhatsky	no flags	Details \| Formatted Diff \| Diff
Patch (29.35 KB, patch) 2011-08-01 02:35 PDT, Yury Semikhatsky	no flags	Details \| Formatted Diff \| Diff
Patch (29.02 KB, patch) 2011-08-01 02:38 PDT, Yury Semikhatsky	pfeldman: review+ webkit.review.bot: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yury Semikhatsky 2011-08-01 02:22:19 PDT

Typing an expression in an iframe leads to multiple "Unsafe JavaScript attempt to access frame..." errors. This happens during console completions evaluation and should be fixed.

Comment 1 Yury Semikhatsky 2011-08-01 02:31:55 PDT

Created attachment 102500 [details]
Patch

Comment 2 WebKit Review Bot 2011-08-01 02:34:25 PDT

Attachment 102500 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Source/WebCore/inspector/InjectedScript.cpp:57:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:67:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:63:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:70:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.cpp:65:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.cpp:99:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:63:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:70:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Yury Semikhatsky 2011-08-01 02:35:52 PDT

Created attachment 102502 [details]
Patch

Comment 4 Yury Semikhatsky 2011-08-01 02:38:05 PDT

Created attachment 102503 [details]
Patch

Comment 5 WebKit Review Bot 2011-08-01 02:38:49 PDT

Attachment 102502 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Source/WebCore/inspector/InjectedScript.cpp:57:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:67:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:63:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:70:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.cpp:65:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.cpp:99:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:63:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:70:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 WebKit Review Bot 2011-08-01 02:40:07 PDT

Attachment 102503 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Source/WebCore/inspector/InjectedScript.cpp:57:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:67:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:63:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:70:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.cpp:65:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.cpp:99:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:63:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:70:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Pavel Feldman 2011-08-01 03:07:47 PDT

Comment on attachment 102503 [details]
Patch

Please file a bug on the stack depth check.

Comment 8 WebKit Review Bot 2011-08-01 03:12:51 PDT

Comment on attachment 102503 [details]
Patch

Attachment 102503 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9287320

New failing tests:
inspector/debugger/debugger-completions-on-call-frame.html

Comment 9 Yury Semikhatsky 2011-08-01 04:43:24 PDT

Committed r92122: <http://trac.webkit.org/changeset/92122>