Bug 65396 – Switch RenderBlock to to new layout types

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Convert RenderBlock to new layout abstraction.

[Emil A Eklund]

Created attachment 102403 [details]
Patch

[Darin Adler]

Comment on attachment 102403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102403&action=review

No EWS because the patch doesn’t apply.

I suggest putting in a patch that only adds the new typedef and is entirely mechanical, and leaving the part that introduces new functions as a separate far smaller patch.

> Source/WebCore/platform/graphics/IntRect.cpp:142
> +IntRect enclosingIntRect(const IntRect& rect)
> +{
> +    return IntRect(rect);
> +}

This must be inlined in the header. We do not want to pay a function call to convert an IntRect to an IntRect.

> Source/WebCore/rendering/LayoutTypes.h:89
> +inline bool layoutUnitEquals(LayoutUnit a, LayoutUnit b)

If the idea here is to use a definition that involves epsilon, then I think you need a different name. After all, == does not use epsilon, so the name "equal" is already taken.

[Emil A Eklund]

Created attachment 102546 [details]
Patch

[Emil A Eklund]

Thanks Darin, made the changes you suggested. Please take another look.

[Eric Seidel (no email)]

Comment on attachment 102546 [details]
Patch

LGTM.  You may want to let Darin take another look too.

[Emil A Eklund]

Thanks Eric,

I'll hold of landing this for another day or so to give Darin a chance to look at it.

[WebKit Review Bot]

Comment on attachment 102546 [details]
Patch

Clearing flags on attachment: 102546

Committed r92712: <http://trac.webkit.org/changeset/92712>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.