Convert RenderBlock to new layout abstraction.
Created attachment 102403 [details] Patch
Comment on attachment 102403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102403&action=review No EWS because the patch doesn’t apply. I suggest putting in a patch that only adds the new typedef and is entirely mechanical, and leaving the part that introduces new functions as a separate far smaller patch. > Source/WebCore/platform/graphics/IntRect.cpp:142 > +IntRect enclosingIntRect(const IntRect& rect) > +{ > + return IntRect(rect); > +} This must be inlined in the header. We do not want to pay a function call to convert an IntRect to an IntRect. > Source/WebCore/rendering/LayoutTypes.h:89 > +inline bool layoutUnitEquals(LayoutUnit a, LayoutUnit b) If the idea here is to use a definition that involves epsilon, then I think you need a different name. After all, == does not use epsilon, so the name "equal" is already taken.
Created attachment 102546 [details] Patch
Thanks Darin, made the changes you suggested. Please take another look.
Comment on attachment 102546 [details] Patch LGTM. You may want to let Darin take another look too.
Thanks Eric, I'll hold of landing this for another day or so to give Darin a chance to look at it.
Comment on attachment 102546 [details] Patch Clearing flags on attachment: 102546 Committed r92712: <http://trac.webkit.org/changeset/92712>
All reviewed patches have been landed. Closing bug.