Bug 65389 - DFG JIT verbose mode provides no details about predictions
Summary: DFG JIT verbose mode provides no details about predictions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-29 14:03 PDT by Filip Pizlo
Modified: 2011-07-29 19:00 PDT (History)
3 users (show)

See Also:


Attachments
the patch (2.29 KB, patch)
2011-07-29 14:07 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (fix style, passes tests) (2.28 KB, patch)
2011-07-29 14:18 PDT, Filip Pizlo
barraclough: review-
Details | Formatted Diff | Diff
the patch (fix review) (2.36 KB, patch)
2011-07-29 15:02 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-07-29 14:03:54 PDT
One tool that the DFG JIT provides for debugging the JIT itself is verbose mode, which results in an IR dump of the procedure being compiled.  But this IR dump does not print any information about predictions.
Comment 1 Filip Pizlo 2011-07-29 14:07:39 PDT
Created attachment 102394 [details]
the patch
Comment 2 WebKit Review Bot 2011-07-29 14:10:37 PDT
Attachment 102394 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGGraph.cpp:138:  Missing space after ,  [whitespace/comma] [3]
Source/JavaScriptCore/dfg/DFGGraph.cpp:139:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2011-07-29 14:18:26 PDT
Created attachment 102396 [details]
the patch (fix style, passes tests)
Comment 4 Gavin Barraclough 2011-07-29 14:35:27 PDT
Comment on attachment 102396 [details]
the patch (fix style, passes tests)

Sorry to be a pain, but (1) this should be ndef NDEBUG only code.  If you find this useful to have in a header to be able to use easily when debugging, then I'd wrap in #ifndef NDEBUG, but you could also consider moving to the NDEBUG section of the .cpp & marking as static.  Also, code on the same lines as labels doesn't match the coding style, there should really be newlines in here.
Comment 5 Filip Pizlo 2011-07-29 15:02:29 PDT
Created attachment 102401 [details]
the patch (fix review)
Comment 6 WebKit Review Bot 2011-07-29 19:00:51 PDT
Comment on attachment 102401 [details]
the patch (fix review)

Clearing flags on attachment: 102401

Committed r92038: <http://trac.webkit.org/changeset/92038>
Comment 7 WebKit Review Bot 2011-07-29 19:00:55 PDT
All reviewed patches have been landed.  Closing bug.