Bug 65378 - [Qt] Add QtWebProcess in PATH at runtime for WebKit2 API auto tests.
Summary: [Qt] Add QtWebProcess in PATH at runtime for WebKit2 API auto tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-29 08:46 PDT by Jocelyn Turcotte
Modified: 2011-08-02 10:02 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.97 KB, patch)
2011-07-29 08:49 PDT, Jocelyn Turcotte
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2011-07-29 08:46:13 PDT
[Qt] Add QtWebProcess in PATH at runtime for WebKit2 API auto tests.
Comment 1 Jocelyn Turcotte 2011-07-29 08:49:04 PDT
Created attachment 102368 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-29 08:51:21 PDT
Attachment 102368 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/tests/util.cpp:20:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2011-08-01 04:27:16 PDT
Comment on attachment 102368 [details]
Patch

Good idea.
Comment 4 Jocelyn Turcotte 2011-08-02 10:02:06 PDT
Committed r92199: <http://trac.webkit.org/changeset/92199>