Bug 65376 – Split RenderBlock::layoutRunsAndFloats into multiple methods

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Alexandru Chiculita]

RenderBlock::layoutRunsAndFloats has a couple of different parts:
1. Determines the first dirty line
2. Detaches the lines starting from the first dirty line
3. Finds the last dirty line
4. Computes the lines starting with the first dirty lines. Also tries to match the last line, or at least somewhere near that.
5. If the last line was matched it links it with the new generated lines.
6. Fix floats after the last line.
7. Repaint some floats that needed repaint during layout

Steps 1, 2, 3 are extracted into separate methods, but 4 and 5 are quite long and still part of RenderBlock::layoutRunsAndFloats.
This patch should extract 4, 5-6 and 7 into 3 separate methods.

It should also help fix bug https://bugs.webkit.org/show_bug.cgi?id=61303, which triggers a position change for a float changes in steps 5 and 6. That happens when doing multi-column incremental layout and the floats have to move from one column to another. It should be much easier to repeat steps from 3 to 6 if it is required to do so.

[Alexandru Chiculita]

Created attachment 102360 [details]
Patch

[WebKit Review Bot]

Comment on attachment 102360 [details]
Patch

Attachment 102360 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9262556

New failing tests:
fast/repaint/line-flow-with-floats-6.html

[Alexandru Chiculita]

Created attachment 102378 [details]
Patch

[Alexandru Chiculita]

Created attachment 102651 [details]
Rebased patch

[Dave Hyatt]

Comment on attachment 102651 [details]
Rebased patch

r=me

[WebKit Review Bot]

Comment on attachment 102651 [details]
Rebased patch

Clearing flags on attachment: 102651

Committed r92207: <http://trac.webkit.org/changeset/92207>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.