Bug 65375 - Style checker should flag usage of 'unsigned int'
Summary: Style checker should flag usage of 'unsigned int'
Status: RESOLVED DUPLICATE of bug 96693
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-29 07:19 PDT by Mihnea Ovidenie
Modified: 2014-03-21 06:17 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2011-07-29 07:19:10 PDT 
Style checker should report the occurrences of 'unsigned int'. Instead of 'unsigned int' we should use only 'unsigned'.
Comment 1 Alexey Proskuryakov 2011-07-29 10:33:52 PDT 
A patch in bug 65176 prompted this bug report.
Comment 2 David Levin 2011-07-29 10:40:08 PDT 
For anyone interested, I'm happy to coach people on how to add rules to the style checker :).
Comment 3 Mihnea Ovidenie 2011-07-31 07:16:16 PDT 
(In reply to comment #2)
> For anyone interested, I'm happy to coach people on how to add rules to the style checker :).

I am interested to learn about style checker and tools, i'll catch you on #webkit.
Comment 4 Julien Chaffraix 2011-11-17 15:36:39 PST 
FYI, I did some very simple grepping to see our usage. Here are the results for Source/WebCore/

$ grep -R "unsigned " .|grep -v "unsigned short"|grep -v "unsigned int"|grep -v "unsigned char"|grep -v "unsigned long"|grep -v ChangeLog|wc -l

5085

$ grep -R "unsigned int" .|grep -v ChangeLog|wc -l

877

Those expressions are very rough but it still looks like it is a fairly wide-spread unwritten rule.
Comment 5 László Langó 2014-03-21 06:17:32 PDT 
http://trac.webkit.org/changeset/128545

*** This bug has been marked as a duplicate of bug 96693 ***