Bug 65372 - check-webkit-style complains about missing config.h in files from Tools/
Summary: check-webkit-style complains about missing config.h in files from Tools/
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-29 06:18 PDT by Ademar Reis
Modified: 2012-03-13 13:44 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ademar Reis 2011-07-29 06:18:08 PDT 
We usually don't use WebCore's config.h in source files from Tools/ (it's not even in the include path most of the time) but check-webkit-style complains.

See for example:
https://bugs.webkit.org/show_bug.cgi?id=65328#c11

"""
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/QtTestBrowser/Qt..." exit_code: 1

Tools/QtTestBrowser/cookiejar.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 7 files

"""
Comment 1 Balazs Kelemen 2012-03-13 13:29:02 PDT 
I agree, it's quite annoying.
Comment 2 David Levin 2012-03-13 13:44:48 PDT 
fwiw, here's the code that implements the checks:
  http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py#L275

I won't have time to look at this in the foreseeable future. My time on WebKit is *extremely* limited these days.