Bug 65368 - [EFL] Implement declared but missing functions.
Summary: [EFL] Implement declared but missing functions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-29 04:52 PDT by Ryuan Choi
Modified: 2011-10-04 16:54 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2011-07-29 04:59 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
patch2 (2.09 KB, patch)
2011-07-29 05:29 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (1.94 KB, patch)
2011-10-04 02:03 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-07-29 04:52:32 PDT
I found that implementation of Cursor::operator=, localizedString was missing although it was declared.
Compiler seems to ignore because WebKit/Efl doesn't use.
(but WebKit2 use them.)
Comment 1 Ryuan Choi 2011-07-29 04:59:12 PDT
Created attachment 102347 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-07-29 05:06:47 PDT
> Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:550
> +    return String::fromUTF8(key);

Passing strlen(key) as a second parameter to fromUTF8 should make things a bit faster on WTFString's side.
Comment 3 Ryuan Choi 2011-07-29 05:29:36 PDT
Created attachment 102350 [details]
patch2
Comment 4 Ryuan Choi 2011-07-29 05:30:36 PDT
(In reply to comment #2)
> > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:550
> > +    return String::fromUTF8(key);
> 
> Passing strlen(key) as a second parameter to fromUTF8 should make things a bit faster on WTFString's side.

Done.
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-07-29 05:35:22 PDT
r+ from my side.
Comment 6 Gyuyoung Kim 2011-08-01 23:07:04 PDT
Comment on attachment 102350 [details]
patch2

LGTM
Comment 7 Ryuan Choi 2011-10-04 02:03:11 PDT
Created attachment 109596 [details]
Patch
Comment 8 WebKit Review Bot 2011-10-04 03:06:46 PDT
Comment on attachment 109596 [details]
Patch

Clearing flags on attachment: 109596

Committed r96581: <http://trac.webkit.org/changeset/96581>
Comment 9 WebKit Review Bot 2011-10-04 03:06:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Darin Adler 2011-10-04 09:31:51 PDT
Thanks for the fixes. I didn’t notice the EFL build breakage.
Comment 11 Gyuyoung Kim 2011-10-04 16:54:55 PDT
(In reply to comment #10)
> Thanks for the fixes. I didn’t notice the EFL build breakage.

No problem. please consider EFL build in future. :-)