I found that implementation of Cursor::operator=, localizedString was missing although it was declared. Compiler seems to ignore because WebKit/Efl doesn't use. (but WebKit2 use them.)
Created attachment 102347 [details] Patch
> Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:550 > + return String::fromUTF8(key); Passing strlen(key) as a second parameter to fromUTF8 should make things a bit faster on WTFString's side.
Created attachment 102350 [details] patch2
(In reply to comment #2) > > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:550 > > + return String::fromUTF8(key); > > Passing strlen(key) as a second parameter to fromUTF8 should make things a bit faster on WTFString's side. Done.
r+ from my side.
Comment on attachment 102350 [details] patch2 LGTM
Created attachment 109596 [details] Patch
Comment on attachment 109596 [details] Patch Clearing flags on attachment: 109596 Committed r96581: <http://trac.webkit.org/changeset/96581>
All reviewed patches have been landed. Closing bug.
Thanks for the fixes. I didn’t notice the EFL build breakage.
(In reply to comment #10) > Thanks for the fixes. I didn’t notice the EFL build breakage. No problem. please consider EFL build in future. :-)