Bug 65354 - [chromium] Reorder functions in LayerRendererChromium.cpp to make bug 58840 easier to review
Summary: [chromium] Reorder functions in LayerRendererChromium.cpp to make bug 58840 e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks: 58840
  Show dependency treegraph
 
Reported: 2011-07-28 19:19 PDT by James Robinson
Modified: 2011-07-29 18:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch (32.35 KB, patch)
2011-07-28 19:21 PDT, James Robinson
kbr: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-07-28 19:19:45 PDT
[chromium] Reorder functions in LayerRendererChromium.cpp to make bug 58840 easier to review
Comment 1 James Robinson 2011-07-28 19:21:07 PDT
Created attachment 102324 [details]
Patch
Comment 2 James Robinson 2011-07-28 19:21:39 PDT
This just shuffles code around but doesn't change anything else.
Comment 3 Adrienne Walker 2011-07-29 11:08:13 PDT
(In reply to comment #2)
> This just shuffles code around but doesn't change anything else.

This seems quite straightforward.  I'll unofficially give it my ok.
Comment 4 Kenneth Russell 2011-07-29 15:19:01 PDT
Comment on attachment 102324 [details]
Patch

OK.
Comment 5 WebKit Review Bot 2011-07-29 16:19:13 PDT
Comment on attachment 102324 [details]
Patch

Rejecting attachment 102324 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1

Last 500 characters of output:
4647d77504c0e855c57bbcaec87f101517e229b6
r92030 = 407c10b1dc3e2cf898131dfc12ff4a89ecd8b615
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9264646
Comment 6 James Robinson 2011-07-29 16:25:06 PDT
I fail so hardcore at ChangeLogs :(
Comment 7 James Robinson 2011-07-29 18:26:17 PDT
Committed r92037: <http://trac.webkit.org/changeset/92037>