RESOLVED FIXED 65342
Implement support for positioned floats in the FloatingObject list of RenderBlock 
https://bugs.webkit.org/show_bug.cgi?id=65342
Summary Implement support for positioned floats in the FloatingObject list of RenderB...
Dave Hyatt
Reported 2011-07-28 13:50:00 PDT
Implement support for positioned floats in the FloatingObject list of RenderBlock.
Attachments
Patch (31.66 KB, patch)
2011-07-28 14:26 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (32.33 KB, patch)
2011-07-28 15:04 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-07-28 14:26:55 PDT
Created attachment 102299 [details] Patch
Dave Hyatt
Comment 2 2011-07-28 15:04:30 PDT
Created attachment 102303 [details] Patch
Sam Weinig
Comment 3 2011-07-29 12:37:43 PDT
Comment on attachment 102303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102303&action=review > Source/WebCore/rendering/RenderBlock.cpp:1364 > + setChildNeedsLayout(true, false); > + layoutBlock(false, pageLogicalHeight, PositionedFloatLayoutPass); > + } else > + setNeedsLayout(false); We really need to updated these to not be bools at some point. > Source/WebCore/rendering/RenderBlock.cpp:1443 > + if (r->m_isDescendant && !r->m_renderer->isPositioned()) It might be helpful to indicate in a comment why you can ignore positioned objects here (e.g. where it is actually handled).
Dave Hyatt
Comment 4 2011-07-29 13:19:33 PDT
Landed in r92004.
Daniel Bates
Comment 5 2011-07-30 23:32:00 PDT
This broke the Chromium Linux Release Flexbox buildbot (non-core): <http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Flexbox%29/builds/1821/steps/compile-webkit/logs/stdio>. Committed build fix in <http://trac.webkit.org/changeset/92072>.
Note You need to log in before you can comment on or make changes to this bug.