Bug 65339 – [Qt] [WK2] Expose web view classes to QML

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Caio Marcelo de Oliveira Filho]

Create a plugin that expose our web view classes for WK2 as QML elements.

[Caio Marcelo de Oliveira Filho]

Created attachment 102292 [details]
Patch

[Caio Marcelo de Oliveira Filho]

Comment on attachment 102292 [details]
Patch

After talking in #qtwebkit with Benjamin and others, I'm working on adding tests for the QML plugin as well.

[Caio Marcelo de Oliveira Filho]

Created attachment 102713 [details]
Patch

[Caio Marcelo de Oliveira Filho]

Benjamin, could you take a look?

This commit depends on https://qt.gitorious.org/qt/qtdeclarative/merge_requests/1, I sent an email for QML devs that might want to merge, but feel welcome to take a look there too :-)

[Benjamin Poulain]

Comment on attachment 102713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102713&action=review

Looks great

> Source/WebKit2/UIProcess/API/qt/qmlplugin/plugin.cpp:37
> +        qmlRegisterUncreatableType<QTouchWebPage>(uri, 5, 0, "TouchWebPage", QString::fromLatin1("Cannot create separate instance of TouchWebPage, use TouchWebView"));

QString::fromLatin1() -> QObject::tr().

[Alexis Menard (darktears)]

Comment on attachment 102713 [details]
Patch

yeahhhh good stuff

[Caio Marcelo de Oliveira Filho]

(In reply to comment #4)
> This commit depends on https://qt.gitorious.org/qt/qtdeclarative/merge_requests/1, I sent an email for QML devs that might want to merge, but feel welcome to take a look there too :-)

For the record, the fix was already merged in qt-declarative:master https://qt.gitorious.org/qt/qtdeclarative/commit/73aa113181fa2295729d24317c187661f740b898

[Caio Marcelo de Oliveira Filho]

Committed r92277: <http://trac.webkit.org/changeset/92277>