Bug 65331 - Web Inspector: [protocol] methods where all parameters are optional should not require empty params object.
Summary: Web Inspector: [protocol] methods where all parameters are optional should no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 11:36 PDT by Pavel Feldman
Modified: 2011-08-01 01:14 PDT (History)
10 users (show)

See Also:


Attachments
Patch (8.02 KB, patch)
2011-07-28 11:41 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-07-28 11:36:24 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-07-28 11:41:32 PDT
Created attachment 102277 [details]
Patch
Comment 2 Yury Semikhatsky 2011-07-31 23:22:50 PDT
Comment on attachment 102277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102277&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:599
> +            protocolErrors->pushString(String::format("'params' object should contain required parameter '\%s' with type '$json'.", name.utf8().data()));

should -> must?
Comment 3 Pavel Feldman 2011-08-01 01:14:11 PDT
Committed r92104: <http://trac.webkit.org/changeset/92104>