Bug 65322 - Web Inspector: [REGRESSION] Inspected tab crashes if navigated with inspector open and there are watch expressions added.
Summary: Web Inspector: [REGRESSION] Inspected tab crashes if navigated with inspector...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 09:56 PDT by Vsevolod Vlasov
Modified: 2011-07-28 16:38 PDT (History)
11 users (show)

See Also:


Attachments
Patch (1.56 KB, patch)
2011-07-28 09:59 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (comments addressed) (4.26 KB, patch)
2011-07-28 10:27 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-07-28 09:56:19 PDT
Inspected tab crashes if navigated with inspector open and there are watch expressions added.
Comment 1 Vsevolod Vlasov 2011-07-28 09:59:12 PDT
Created attachment 102265 [details]
Patch
Comment 2 Pavel Feldman 2011-07-28 10:07:48 PDT
Comment on attachment 102265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102265&action=review

> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:66
>          scriptState = getDefaultInspectedState();

Add you should do *errorString = "No frame with id is available.";
Comment 3 Vsevolod Vlasov 2011-07-28 10:27:35 PDT
Created attachment 102268 [details]
Patch (comments addressed)
Comment 4 WebKit Review Bot 2011-07-28 16:38:00 PDT
Comment on attachment 102268 [details]
Patch (comments addressed)

Clearing flags on attachment: 102268

Committed r91956: <http://trac.webkit.org/changeset/91956>
Comment 5 WebKit Review Bot 2011-07-28 16:38:05 PDT
All reviewed patches have been landed.  Closing bug.