Bug 65319 – [GTK] Use GRefPtr for SOUP_TYPE_CONTENT_DECODER in WebKit2.

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: WebKit2

[Lukasz Slachciak]

Use GRefPtr for decoder (SOUP_TYPE_CONTENT_DECODER) reference tracking, the same way as other SoupSessionFeature's.

[Lukasz Slachciak]

Created attachment 102257 [details]
SOUP_TYPE_CONTENT_DECODER fix

[Martin Robinson]

Comment on attachment 102257 [details]
SOUP_TYPE_CONTENT_DECODER fix

View in context: https://bugs.webkit.org/attachment.cgi?id=102257&action=review

> Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:65
> -    soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
> +    GRefPtr<SoupSessionFeature> decoder = adoptGRef(static_cast<SoupSessionFeature*>(g_object_new(SOUP_TYPE_CONTENT_DECODER, NULL)));
> +    soup_session_add_feature(session, decoder.get());

Why is this an improvement?

[Martin Robinson]

(In reply to comment #2)
> (From update of attachment 102257 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102257&action=review
> 
> > Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:65
> > -    soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
> > +    GRefPtr<SoupSessionFeature> decoder = adoptGRef(static_cast<SoupSessionFeature*>(g_object_new(SOUP_TYPE_CONTENT_DECODER, NULL)));
> > +    soup_session_add_feature(session, decoder.get());
> 
> Why is this an improvement?

By this I mean, why don't we just use soup_session_add_feature_by_type everywhere?

[Lukasz Slachciak]

Comment on attachment 102257 [details]
SOUP_TYPE_CONTENT_DECODER fix

View in context: https://bugs.webkit.org/attachment.cgi?id=102257&action=review

>>> Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:65
>>> +    soup_session_add_feature(session, decoder.get());
>> 
>> Why is this an improvement?
> 
> By this I mean, why don't we just use soup_session_add_feature_by_type everywhere?

I wanted just to have all features initialized in the same way. In fact we don't need to use GRefPtr here.
For me it  looks like that we can have soup_session_add_feature_by_type for all features.

[Martin Robinson]

If that's possible, let's do that. :) It will cut down on the number of lines of code.

[Sergio Villar Senin]

The patch added after bug 68602 changes the way we initialize libsoup features so this is no longer needed.