Bug 65313 – MinGW-w64 - JIT causes build failure

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Jonathan Liu]

JIT shouldn't be enabled on MinGW-w64 as it is unstable and causes crash when executing JavaScript.

The following should be added to JavaScriptCore/wtf/Platform.h:
/* JIT is not implemented for 64 bit on MinGW-w64 */
#if !defined(ENABLE_JIT) && COMPILER(MINGW64) && CPU(X86_64)
#define ENABLE_JIT 0
#endif

[Alexey Proskuryakov]

Would you be willing to contribute this code to WebKit as described in <http://www.webkit.org/coding/contributing.html>?

I do not mean to diminish the contribution you made already by pointing out this bug, but historically, patches that aren't submitted according to the process almost never get landed.

I believe this wouldn't work on 64-bit MSVC either. IMHO I think that the COMPILER(MINGW64) check is superfluous (and wrong). Last I knew, Win64 had no working JIT.

[Jonathan Liu]

This issue causes build failure as indicated in bug 61235.

[Jonathan Liu]

Created attachment 105446 [details]
proposed patch

[Jonathan Liu]

(In reply to comment #1)
> Would you be willing to contribute this code to WebKit as described in <http://www.webkit.org/coding/contributing.html>?
> 
> I do not mean to diminish the contribution you made already by pointing out this bug, but historically, patches that aren't submitted according to the process almost never get landed.

Patch contributed as requested.

[WebKit Review Bot]

Attachment 105446 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jonathan Liu]

Created attachment 105447 [details]
proposed patch

[WebKit Review Bot]

Comment on attachment 105447 [details]
proposed patch

Clearing flags on attachment: 105447

Committed r93950: <http://trac.webkit.org/changeset/93950>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ademar Reis]

Revision r93950 cherry-picked into qtwebkit-2.2 with commit b017396 <http://gitorious.org/webkit/qtwebkit/commit/b017396>

[Kai Koehne]

Unfortunately this is broken again in latest qtwebkit: 

jit\ExecutableAllocatorFixedVMPool.cpp:34:22: fatal error: sys/mman.h: No such file or directory 

I've yet to find out what goes wrong this time ...

[Kai Koehne]

Created another bug report for the regression: https://bugs.webkit.org/show_bug.cgi?id=97772