Bug 65304 - [Chromium] Add form() function to access parent WebFormElement from WebFormControlElement.
Summary: [Chromium] Add form() function to access parent WebFormElement from WebFormCo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Naoki Takano
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-27 23:24 PDT by Naoki Takano
Modified: 2011-07-28 22:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2011-07-27 23:27 PDT, Naoki Takano 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naoki Takano 2011-07-27 23:24:33 PDT 
[Chromium] Add form() function to access parent WebFormElement from WebFormControlElement.
Comment 1 Naoki Takano 2011-07-27 23:27:00 PDT 
Created attachment 102229 [details]
Patch
Comment 2 Naoki Takano 2011-07-27 23:32:49 PDT 
Please review.
Comment 3 Ilya Sherman 2011-07-28 02:19:38 PDT 
Comment on attachment 102229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102229&action=review

Looks ok to me, but I am not a WebKit reviewer.

> Source/WebKit/chromium/src/WebFormControlElement.cpp:35
> +#include "HTMLFormElement.h"

nit: Why do you need to include this header here?
Comment 4 Darin Fisher (:fishd, Google) 2011-07-28 10:07:47 PDT 
Comment on attachment 102229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102229&action=review

>> Source/WebKit/chromium/src/WebFormControlElement.cpp:35
>> +#include "HTMLFormElement.h"
> 
> nit: Why do you need to include this header here?

he needs that so that the WebFormElement(const PassRefPtr<HTMLFormElement>&) constructor can be called.  that requires the definition of the HTMLFormElement class.
Comment 5 WebKit Review Bot 2011-07-28 22:32:36 PDT 
Comment on attachment 102229 [details]
Patch

Clearing flags on attachment: 102229

Committed r91975: <http://trac.webkit.org/changeset/91975>
Comment 6 WebKit Review Bot 2011-07-28 22:32:41 PDT 
All reviewed patches have been landed.  Closing bug.