WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 65300
Improve StringImpl::stripWhiteSpace() and simplifyWhiteSpace().
https://bugs.webkit.org/show_bug.cgi?id=65300
Summary
Improve StringImpl::stripWhiteSpace() and simplifyWhiteSpace().
Kent Tamura
Reported
2011-07-27 20:50:53 PDT
http://trac.webkit.org/changeset/91837
should have made the performance of stripWhiteSpace() and simplifyWhiteSpace() worse.
Attachments
Patch
(6.35 KB, patch)
2011-07-27 21:37 PDT
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
2011-07-27 21:37:02 PDT
Created
attachment 102224
[details]
Patch
Kent Tamura
Comment 2
2011-07-27 21:40:09 PDT
(In reply to
comment #1
)
> Created an attachment (id=102224) [details] > Patch
I confirmed the compiled code of stripWhiteSpace() contained inlined stripMatchedCharacters() and inlined isSpaceOrNewLine(), and the compiled code of simplifyWhiteSpace(9 contained inlined simplifyMatchedCharactersToSpace() and inlined isSpaceOrNewLine().
Darin Adler
Comment 3
2011-07-27 23:42:03 PDT
Comment on
attachment 102224
[details]
Patch OK. Thanks.
Kent Tamura
Comment 4
2011-07-27 23:57:28 PDT
Comment on
attachment 102224
[details]
Patch Thank you for reviewing!
WebKit Review Bot
Comment 5
2011-07-28 00:38:39 PDT
Comment on
attachment 102224
[details]
Patch Clearing flags on attachment: 102224 Committed
r91913
: <
http://trac.webkit.org/changeset/91913
>
WebKit Review Bot
Comment 6
2011-07-28 00:38:43 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug