Bug 65300 - Improve StringImpl::stripWhiteSpace() and simplifyWhiteSpace().
Summary: Improve StringImpl::stripWhiteSpace() and simplifyWhiteSpace().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-27 20:50 PDT by Kent Tamura
Modified: 2011-07-28 00:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.35 KB, patch)
2011-07-27 21:37 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-07-27 20:50:53 PDT 
http://trac.webkit.org/changeset/91837 should have made the performance of stripWhiteSpace() and simplifyWhiteSpace() worse.
Comment 1 Kent Tamura 2011-07-27 21:37:02 PDT 
Created attachment 102224 [details]
Patch
Comment 2 Kent Tamura 2011-07-27 21:40:09 PDT 
(In reply to comment #1)
> Created an attachment (id=102224) [details]
> Patch

I confirmed the compiled code of stripWhiteSpace() contained inlined stripMatchedCharacters() and inlined isSpaceOrNewLine(), and the compiled code of simplifyWhiteSpace(9 contained inlined simplifyMatchedCharactersToSpace() and inlined isSpaceOrNewLine().
Comment 3 Darin Adler 2011-07-27 23:42:03 PDT 
Comment on attachment 102224 [details]
Patch

OK. Thanks.
Comment 4 Kent Tamura 2011-07-27 23:57:28 PDT 
Comment on attachment 102224 [details]
Patch

Thank you for reviewing!
Comment 5 WebKit Review Bot 2011-07-28 00:38:39 PDT 
Comment on attachment 102224 [details]
Patch

Clearing flags on attachment: 102224

Committed r91913: <http://trac.webkit.org/changeset/91913>
Comment 6 WebKit Review Bot 2011-07-28 00:38:43 PDT 
All reviewed patches have been landed.  Closing bug.